Simplify dynamic ipfilter sysctls.
ClosedPublic
Actions

Authored by jhb on Jan 4 2021, 9:39 PM.

Tags

None

Referenced Files

	F103014242: D27961.diff
	Tue, Nov 19, 8:24 PM

	Unknown Object (File)
	Mon, Nov 11, 1:12 PM

	Unknown Object (File)
	Mon, Nov 11, 6:38 AM

	Unknown Object (File)
	Mon, Nov 11, 4:18 AM

	Unknown Object (File)
	Mon, Nov 11, 3:53 AM

	Unknown Object (File)
	Mon, Nov 11, 3:14 AM

	Unknown Object (File)
	Sun, Nov 10, 3:58 AM

	Unknown Object (File)
	Tue, Oct 29, 7:04 PM

View All 48 Files

Subscribers

imp

Details

Reviewers

bz
cy

Commits

rGbb4cbd0fcf3e: Simplify dynamic ipfilter sysctls.
rGd86d3194955c: Simplify dynamic ipfilter sysctls.

Summary

Pass the structure offset in arg2 instead of arg1. This avoids
having to undo the pointer arithmetic on arg1. Instead arg2 can
be used directly as an offset relative to the desired structure.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 35929
Build 32818: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 4 2021, 9:39 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 4 2021, 9:39 PM

jhb requested review of this revision.Jan 4 2021, 9:39 PM

Harbormaster completed remote builds in B35929: Diff 81648.Jan 4 2021, 9:39 PM

Ping @cy

Definitely an improvement. Thank you.

This revision is now accepted and ready to land.Jan 20 2021, 5:17 PM

Closed by commit rGd86d3194955c: Simplify dynamic ipfilter sysctls. (authored by jhb). · Explain WhyJan 21 2021, 12:35 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGd86d3194955c: Simplify dynamic ipfilter sysctls..

cy added a commit: rGbb4cbd0fcf3e: Simplify dynamic ipfilter sysctls..Jul 14 2022, 9:33 PM

Revision Contents
Changeset List

Path

Size

sys/

contrib/

ipfilter/

netinet/

mlfk_ipl.c

86 lines

Diff 81648

View Options

sys/contrib/ipfilter/netinet/mlfk_ipl.c

Simplify dynamic ipfilter sysctls.ClosedPublicActions