Fix vnode locking bug in fuse_vnop_copy_file_range
ClosedPublic
Actions

Authored by asomers on Jan 3 2021, 3:32 AM.

Details

Reviewers

cem

Commits

rG17a82e6af8e2: Fix vnode locking bug in fuse_vnop_copy_file_range

Summary

MFC-With: 92bbfe1f0d1f1c4436d1f064a16e5aaf682526ba

Test Plan

fusefs test suite with DEBUG_VFS_LOCKS

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35911
Build 32800: arc lint + arc unit

Event Timeline

asomers created this revision.Jan 3 2021, 3:32 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 3 2021, 3:32 AM

asomers requested review of this revision.Jan 3 2021, 3:32 AM

Harbormaster completed remote builds in B35902: Diff 81568.Jan 3 2021, 3:32 AM

cem added inline comments.Jan 3 2021, 12:43 PM

sys/fs/fuse/fuse_vnops.c
681–722	Need `goto unlock` instead of `return (err);` to avoid leaking the locks, I think.

Don't leak locks on fufh lookup failure

Harbormaster completed remote builds in B35911: Diff 81588.Jan 3 2021, 4:34 PM

cem accepted this revision.Jan 3 2021, 4:49 PM

This revision is now accepted and ready to land.Jan 3 2021, 4:49 PM

Closed by commit rG17a82e6af8e2: Fix vnode locking bug in fuse_vnop_copy_file_range (authored by asomers). · Explain WhyJan 3 2021, 6:20 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG17a82e6af8e2: Fix vnode locking bug in fuse_vnop_copy_file_range.

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

fuse_vnops.c

16 lines

Diff 81588

View Options

Fix vnode locking bug in fuse_vnop_copy_file_rangeClosedPublicActions