Page MenuHomeFreeBSD
Differential D27841

Add Chacha20-Poly1305 support in the OCF backend for KTLS.
ClosedPublic
Actions

Authored by jhb on Dec 30 2020, 12:54 AM.
Tags
None
Referenced Files
F107562994: D27841.diff
Wed, Jan 15, 10:46 PM
Unknown Object (File)
Tue, Jan 14, 11:13 AM
Unknown Object (File)
Mon, Jan 13, 2:20 AM
Unknown Object (File)
Dec 12 2024, 7:28 PM
Unknown Object (File)
Dec 7 2024, 12:12 AM
Unknown Object (File)
Nov 23 2024, 2:48 PM
Unknown Object (File)
Nov 21 2024, 6:37 AM
Unknown Object (File)
Nov 16 2024, 12:17 PM
View All Files
Subscribers
imp

Details

Reviewers
jmg
gallatin
Commits
rG98641c00a3ae: Add Chacha20-Poly1305 support in the OCF backend for KTLS.
rG4dd6800e22b0: Add Chacha20-Poly1305 support in the OCF backend for KTLS.
Summary

This supports Chacha20-Poly1305 for both send and receive for TLS 1.2
and for send in TLS 1.3.

Test Plan

Tested via openssl s_server with KTLS in a VM against a host running software openssl s_client with chacha20 ciphers.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 35783
Build 32672: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 30 2020, 12:54 AM
Herald added a reviewer: jmg. · View Herald TranscriptDec 30 2020, 12:54 AM
Herald added a subscriber: imp. · View Herald Transcript
jhb requested review of this revision.Dec 30 2020, 12:54 AM
Harbormaster completed remote builds in B35783: Diff 81357.Dec 30 2020, 12:54 AM
jhb added a parent revision: D27839: Add Chacha20-Poly1305 as a KTLS cipher suite..Dec 30 2020, 12:54 AM
jhb edited the test plan for this revision. (Show Details)Dec 30 2020, 1:01 AM
jhb added a reviewer: gallatin.
jhb edited the summary of this revision. (Show Details)Feb 17 2021, 2:00 AM
jhb updated this revision to Diff 84151.Feb 17 2021, 10:27 PM
  • Rebase.
Harbormaster completed remote builds in B37130: Diff 84151.Feb 17 2021, 10:27 PM
gallatin accepted this revision.Feb 17 2021, 11:54 PM

Maybe add a comment for the else cases saying that they are chacha?

sys/opencrypto/ktls_ocf.c
359–366

Maybe a switch, or at least a comment for the else cases that they are chacha?

This revision is now accepted and ready to land.Feb 17 2021, 11:54 PM
jhb marked an inline comment as done.Feb 18 2021, 5:29 PM
jhb added inline comments.
sys/opencrypto/ktls_ocf.c
359–366

I'll add a comment about Chacha using the TLS 1.3 IV construction in TLS 1.2.

Closed by commit rG4dd6800e22b0: Add Chacha20-Poly1305 support in the OCF backend for KTLS. (authored by jhb). · Explain WhyFeb 18 2021, 5:55 PM
This revision was automatically updated to reflect the committed changes.
jhb marked an inline comment as done.
jhb added a commit: rG4dd6800e22b0: Add Chacha20-Poly1305 support in the OCF backend for KTLS..
jhb added a commit: rG98641c00a3ae: Add Chacha20-Poly1305 support in the OCF backend for KTLS..Nov 23 2021, 11:13 PM

Revision Contents
Changeset List

PathSize
sys/
opencrypto/
110 lines

Diff 81357

View Options

sys/opencrypto/ktls_ocf.c

Loading...