Page MenuHomeFreeBSD

pf: Convert pfi_kkif to use counter_u64
ClosedPublic

Authored by kp on Dec 24 2020, 3:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 24, 2:44 PM
Unknown Object (File)
Sun, Apr 20, 7:49 PM
Unknown Object (File)
Thu, Apr 17, 2:16 AM
Unknown Object (File)
Tue, Apr 15, 3:29 PM
Unknown Object (File)
Mon, Apr 14, 7:26 PM
Unknown Object (File)
Fri, Apr 11, 6:54 PM
Unknown Object (File)
Mar 24 2025, 7:27 AM
Unknown Object (File)
Mar 5 2025, 8:07 AM

Details

Summary

Improve caching behaviour by using counter_u64 rather than variables
shared between cores. Expect a minor performance improvement.

MFC after: 2 weeks
Sponsored by: Orange Business Services

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Dec 24 2020, 3:48 PM

Looks good, modulo minor initialisation nit/remark.

sys/netpfil/pf/pf_if.c
226–245

Is there a point in M_ZEROing? As far as I can tell, everything is explicitly initialised later. Or you could pf_kkif_zero() to make it even clearer.

sys/netpfil/pf/pf_if.c
226–245

Paranoia for one, but also because otherwise we can't tell which of the counter allocations have failed and can't safely free in pfi_kkif_free().

Happily this is not in the data path, so we don't actually do this very often. A little bit of extra memory writing here isn't going to hurt anything,

Works for me! Thanks for clarifying.

This revision is now accepted and ready to land.Dec 30 2020, 11:39 AM
This revision was automatically updated to reflect the committed changes.