Page MenuHomeFreeBSD
Differential D27637

truss: fix handling of 64-bit arguments/return values for compat32
ClosedPublic
Actions

Authored by arichardson on Dec 16 2020, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 5:24 PM
Unknown Object (File)
Oct 12 2024, 10:50 AM
Unknown Object (File)
Oct 2 2024, 12:54 PM
Unknown Object (File)
Sep 29 2024, 10:37 PM
Unknown Object (File)
Sep 24 2024, 5:29 PM
Unknown Object (File)
Sep 16 2024, 6:54 AM
Unknown Object (File)
Sep 8 2024, 2:36 PM
Unknown Object (File)
Sep 8 2024, 1:19 AM
View All 50 Files
Subscribers
imp

Details

Reviewers
jhb
Commits
rGed1563aba95b: truss: fix handling of 64-bit arguments/return values for compat32
rG8ba2e89e987c: truss: fix handling of 64-bit arguments/return values for compat32
Summary

Deciding whether to combine two values to a 64-bit one should be based on
the process ABI, and not dependent on whether truss is compiled for an
LP64 ABI. This is a follow-up cleanup for D27625. I found this while
looking for uses of the __LP64__ macro (since using this is wrong for
CHERI systems).

Test Plan

still works. Since I tested on AMD64 and all syscalls in the trace have their quad argument last there was no difference in the output. Should fix output for compat32 on MIPS64 though.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Dec 16 2020, 6:52 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 16 2020, 6:52 PM
arichardson requested review of this revision.Dec 16 2020, 6:52 PM
Harbormaster completed remote builds in B35445: Diff 80778.Dec 16 2020, 6:52 PM
arichardson added a parent revision: D27625: truss: improved support for decoding compat32 arguments.Dec 16 2020, 8:55 PM
arichardson edited the summary of this revision. (Show Details)
arichardson added a comment.Mar 25 2021, 1:55 PM

ping?

arichardson added a comment.Apr 21 2021, 10:57 AM

ping? I'd like to include this commit when I update https://github.com/CTSRD-CHERI/cheribsd/pull/692

jhb added inline comments.Apr 22 2021, 9:56 PM
usr.bin/truss/syscalls.c
1917

I think you can safely axe this comment.

1929

We don't use the PRI macros in FreeBSD. Typically we use '%j' and cast to uintmax_t instead.

arichardson updated this revision to Diff 90870.Jun 14 2021, 10:30 AM
arichardson marked 2 inline comments as done.

address feedback

Harbormaster completed remote builds in B39904: Diff 90870.Jun 14 2021, 10:31 AM
arichardson updated this revision to Diff 90871.Jun 14 2021, 10:31 AM

clang-format

Harbormaster completed remote builds in B39905: Diff 90871.Jun 14 2021, 10:32 AM
jhb accepted this revision.Jun 14 2021, 11:30 PM
This revision is now accepted and ready to land.Jun 14 2021, 11:30 PM
Closed by commit rG8ba2e89e987c: truss: fix handling of 64-bit arguments/return values for compat32 (authored by arichardson). · Explain WhyJun 16 2021, 4:21 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG8ba2e89e987c: truss: fix handling of 64-bit arguments/return values for compat32.
arichardson added a commit: rGed1563aba95b: truss: fix handling of 64-bit arguments/return values for compat32.Jul 5 2021, 9:49 AM

Revision Contents
Changeset List

PathSize
usr.bin/
truss/
40 lines

Diff 90967

View Options

usr.bin/truss/syscalls.c

Loading...