Page MenuHomeFreeBSD
Differential D27543

look(1): Add EXAMPLES section
ClosedPublic
Actions

Authored by fernape on Dec 10 2020, 4:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 13 2024, 12:45 AM
Unknown Object (File)
Oct 13 2024, 12:45 AM
Unknown Object (File)
Oct 13 2024, 12:44 AM
Unknown Object (File)
Oct 13 2024, 12:44 AM
Unknown Object (File)
Oct 13 2024, 12:15 AM
Unknown Object (File)
Oct 2 2024, 1:00 AM
Unknown Object (File)
Sep 9 2024, 4:26 AM
Unknown Object (File)
Sep 4 2024, 6:28 PM
View All 51 Files
Subscribers
bcr
gbe
imp
Contributor Reviews (src)

Details

Reviewers
None
Group Reviewers
manpages
Commits
rGf3f16c31fea2: look(1): Add EXAMPLES section
Summary

Add two simple examples. In this case I opted to show a small portion of the
output since it helps to understand what the tool does.

It shows the use of the -t flag too.

Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./look.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35305
Build 32237: arc lint + arc unit

Event Timeline

fernape created this revision.Dec 10 2020, 4:07 PM
Herald added a reviewer: manpages. · View Herald TranscriptDec 10 2020, 4:07 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Dec 10 2020, 4:07 PM
Harbormaster completed remote builds in B35305: Diff 80526.Dec 10 2020, 4:08 PM
gbe added a subscriber: gbe.Dec 10 2020, 4:13 PM
gbe added inline comments.
usr.bin/look/look.1
111

comma after above.

117

What is the default file?

fernape updated this revision to Diff 80540.Dec 10 2020, 6:42 PM

Add , after "above" (gbe@)

Add an explicit reference to the default file where look searches if no file is
specified (gbe@)

Harbormaster completed remote builds in B35312: Diff 80540.Dec 10 2020, 6:42 PM
fernape marked 2 inline comments as done.Dec 10 2020, 6:43 PM
fernape added inline comments.
usr.bin/look/look.1
117

It is the one used if no file is specified. It is referenced in `FILES``` but it is probably better to explicitly name it in the example.

bcr accepted this revision as: manpages.Dec 28 2020, 5:53 PM
bcr added a subscriber: bcr.

Look good to me. Thank you!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 29 2020, 6:56 PM
Closed by commit rGf3f16c31fea2: look(1): Add EXAMPLES section (authored by fernape). · Explain Why
This revision was automatically updated to reflect the committed changes.
fernape marked an inline comment as done.
fernape added a commit: rGf3f16c31fea2: look(1): Add EXAMPLES section.
fernape added a comment.Dec 29 2020, 6:57 PM
In D27543#621440, @bcr wrote:

Look good to me. Thank you!

Thank you both for the review!

Revision Contents
Changeset List

PathSize
usr.bin/
look/
28 lines

Diff 80526

View Options

usr.bin/look/look.1

Loading...