ossl: split out x86 bits to x86/ossl_cpuid.c
ClosedPublic
Actions

Authored by mhorne on Nov 26 2020, 8:26 PM.

Details

Reviewers

jhb
jmg

Commits

rS368349: ossl: split out x86 bits to x86/ossl_cpuid.c

Summary

Make room for adding arm64 support to this driver by moving the
x86-specific feature parsing to a separate file.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35062
Build 32037: arc lint + arc unit

Event Timeline

mhorne requested review of this revision.Nov 26 2020, 8:26 PM

mhorne created this revision.

Harbormaster completed remote builds in B35059: Diff 80037.Nov 26 2020, 8:26 PM

Move common ossl files to conf/files.

Harbormaster completed remote builds in B35062: Diff 80040.Nov 26 2020, 9:10 PM

mhorne mentioned this in D27390: ossl: port to arm64.Nov 26 2020, 9:21 PM

emaste added a subscriber: emaste.Nov 26 2020, 9:42 PM

In general looks ok. My only wiggle is that right now sys/crypto/openssl/<arch> only contains generated files from OpenSSL (and is shared with the userland libcrypto build via .PATH). The other approach would be to call this new file 'sys/crypto/openssl/ossl_x86.c' and add it to SRCS.amd64 and SRCS.i386 explicitly. I'm not strictly tied to that approach however.

In D27388#613044, @jhb wrote:

In general looks ok. My only wiggle is that right now sys/crypto/openssl/<arch> only contains generated files from OpenSSL (and is shared with the userland libcrypto build via .PATH). The other approach would be to call this new file 'sys/crypto/openssl/ossl_x86.c' and add it to SRCS.amd64 and SRCS.i386 explicitly. I'm not strictly tied to that approach however.

I see, it would be best kept out of that folder then. Naming it ossl_x86.c seems reasonable to me.