syslogd: Added -M option that limit maximum length of forwarded message
ClosedPublic
Actions

Authored by dmitry.wagin_ya.ru on Nov 13 2020, 3:28 PM.

Details

Reviewers

ed
markj

Group Reviewers

manpages

Commits

rG55b6c85e0c25: syslogd: Increase message size limits
rG2d82b47a5b4e: syslogd: Increase message size limits

Summary

There's an enhancement to syslogd(8).

Added -M option that limit maximum length of forwarded message.
Initially syslogd had forwarded 1024-bytes messages (RFC 3164). But after D15011 forwarded messages has been truncated to 480 octets (for IPv4).
The patch allows to truncate messages by -M option (default 1024).
MAXLINE constant has been increased up to 8192 octets, corresponded to D27205.
Replaced bootfile[] size for MAXPATHLEN used in getbootfile(3) as a returned value. Using (MAXLINE+1) as a size for bootfile[] is excessive.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dmitry.wagin_ya.ru created this revision.Nov 13 2020, 3:28 PM

Herald added a reviewer: manpages. · View Herald TranscriptNov 13 2020, 3:28 PM

Herald added a subscriber: imp. · View Herald Transcript

dmitry.wagin_ya.ru requested review of this revision.Nov 13 2020, 3:28 PM

0mp added a subscriber: 0mp.Nov 13 2020, 4:22 PM

0mp added inline comments.

usr.sbin/syslogd/syslogd.8
248	Please start new sentences with new lines.
248	How about Set the limit on the length of forwarded message? Also, I'm not sure but it might be necessary to add the before minimum and maximum.
249
usr.sbin/syslogd/syslogd.c
397	Is this desired? MAXPATHLEN is not mentioned in the description of the change.

dmitry.wagin_ya.ru added inline comments.Nov 13 2020, 5:00 PM

usr.sbin/syslogd/syslogd.c
397	Replaced bootfile[] size for MAXPATHLEN used in getbootfile(3) as a returned value. Using (MAXLINE+1) as a size for bootfile[] is excessive.

dmitry.wagin_ya.ru edited the summary of this revision. (Show Details)Nov 13 2020, 5:01 PM

man:
Moved new sentences to new lines.
Added articles.

dmitry.wagin_ya.ru marked 3 inline comments as done.Nov 13 2020, 5:17 PM

dmitry.wagin_ya.ru added inline comments.

usr.sbin/syslogd/syslogd.8
248	I don't know about it. I'm not an English-native, sorry.

dmitry.wagin_ya.ru marked an inline comment as done.Nov 13 2020, 5:18 PM

drtr0jan_yandex.ru added a subscriber: drtr0jan_yandex.ru.Jan 12 2021, 7:34 PM

ping

Initially syslogd had forwarded 1024-bytes messages (RFC 3164). But after D15011 forwarded messages has been truncated to 480 octets (for IPv4).

The reasoning is given in RFC 5426. I tend to agree that this is too conservative.

usr.sbin/syslogd/syslogd.c
673	I suggest "minimum maximum length of forwarded messages is 480 bytes".
721	I would write it a bit shorter, e.g., "RFC 3164 messages may not exceed 1024 bytes"