Page MenuHomeFreeBSD

vmimage.subr: noisier failure for unsupported targets
ClosedPublic

Authored by mhorne on Oct 28 2020, 2:08 PM.
Tags
None
Referenced Files
F107915370: D26985.diff
Sun, Jan 19, 9:03 AM
Unknown Object (File)
Dec 7 2024, 6:03 PM
Unknown Object (File)
Oct 18 2024, 8:02 AM
Unknown Object (File)
Sep 28 2024, 3:10 AM
Unknown Object (File)
Sep 18 2024, 2:34 AM
Unknown Object (File)
Sep 5 2024, 6:32 AM
Unknown Object (File)
Aug 19 2024, 2:41 AM
Unknown Object (File)
Aug 19 2024, 12:33 AM
Subscribers

Details

Summary

The return code of write_partition_layout() doesn't bubble up, so an
invocation of make vm-release for an incorrect/unsupported target will
appear to succeed while make vm-install will fail due to missing
files. This isn't a common point of failure, but is worth handling
properly.

Upgrade this case to print a message to stderr, and exit in place. This
is okay to do since at this point in the execution of mk-vmimage.sh,
cleanup() has already been run.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34435
Build 31539: arc lint + arc unit