Page MenuHomeFreeBSD

[llvm] Use 32 bit atomic on freebsd mips
ClosedPublic

Authored by adrian on Oct 13 2020, 10:54 PM.
Tags
None
Referenced Files
F107825024: D26774.diff
Sat, Jan 18, 1:13 PM
F107760920: D26774.diff
Sat, Jan 18, 12:40 AM
Unknown Object (File)
Nov 19 2024, 9:06 AM
Unknown Object (File)
Nov 6 2024, 5:25 PM
Unknown Object (File)
Oct 26 2024, 11:59 AM
Unknown Object (File)
Oct 26 2024, 11:59 AM
Unknown Object (File)
Oct 26 2024, 11:59 AM
Unknown Object (File)
Oct 26 2024, 11:40 AM
Subscribers

Details

Summary

gcc for mips32 doesn't include libatomic and doesn't generate
atomic sequences; so this just fails to link.

Instead, just use 32 bit for mips32/mips64.

(I haven't found a nice way to detect 32 or 64 bit mips here
without other header pollution, but it should be fine for freebsd/mips.)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this is fine for now. Upstream will want to centralize the define somewhere in __config, but we can take that discussion there.

This revision is now accepted and ready to land.Oct 16 2020, 6:58 PM