Drop a useless assignment, and add a KASSERT to make sure it really was useless.
ClosedPublic
Actions

Authored by trasz on Oct 3 2020, 3:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 20, 2:10 AM

	Unknown Object (File)
	Mon, Jan 20, 2:10 AM

	Unknown Object (File)
	Sun, Jan 19, 8:53 PM

	Unknown Object (File)
	Sat, Jan 18, 5:36 PM

	Unknown Object (File)
	Thu, Jan 9, 7:43 AM

	Unknown Object (File)
	Dec 10 2024, 5:02 AM

	Unknown Object (File)
	Dec 10 2024, 3:52 AM

	Unknown Object (File)
	Nov 7 2024, 4:41 AM

Subscribers

Details

Reviewers

jhb

Group Reviewers

riscv

Commits

rS366454: Drop useless assignment, and add a KASSERT to make sure it really was useless.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33964
Build 31157: arc lint + arc unit

Event Timeline

trasz created this revision.Oct 3 2020, 3:42 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 3 2020, 3:42 PM

trasz requested review of this revision.Oct 3 2020, 3:42 PM

Harbormaster completed remote builds in B33964: Diff 77816.Oct 3 2020, 3:42 PM

trasz added a reviewer: riscv.Oct 3 2020, 3:42 PM

Looks good to me.

It was nice as documentation, but the kassert is equally fine for that purpose. I would echo Jess in that arm64 probably should be similarly updated.

This revision is now accepted and ready to land.Oct 5 2020, 5:48 PM

Closed by commit rS366454: Drop useless assignment, and add a KASSERT to make sure it really was useless. (authored by trasz). · Explain WhyOct 5 2020, 6:42 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS366454: Drop useless assignment, and add a KASSERT to make sure it really was useless..

I don't see a similar assignment for arm64, though.

Revision Contents
Changeset List

Path

Size

sys/

riscv/

trap.c

4 lines

Diff 77816

View Options

Drop a useless assignment, and add a KASSERT to make sure it really was useless.ClosedPublicActions