Differential D26508

Shrink sysent from 48 to 32 bytes
ClosedPublic
Actions

Authored by trasz on Sep 21 2020, 12:52 PM.

Details

Reviewers

kib

Commits

rS366201: Shrink struct sysent from 48 to 32 bytes (on LP64; on ILP32 its probably

Summary

Shrink sysent from 48 to 32 bytes by shrinking some entries and reordering them.

This depends on https://reviews.freebsd.org/D26530.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Sep 21 2020, 12:52 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 21 2020, 12:52 PM

trasz requested review of this revision.Sep 21 2020, 12:52 PM

Harbormaster completed remote builds in B33689: Diff 77289.Sep 21 2020, 12:53 PM

You can shrink it to 32 bytes:
sy_nargs can be uint8_t, we definitely do not need more than 255 arguments
sy_flags can be uint8_t as well.

sigsys_gmail.com added a subscriber: sigsys_gmail.com.Sep 21 2020, 4:20 PM

Down to 32 bytes.

Harbormaster completed remote builds in B33765: Diff 77424.Sep 23 2020, 2:02 PM

trasz retitled this revision from Shrink sysent from 48 to 40 bytes to Shrink sysent from 48 to 32 bytes.Sep 23 2020, 2:02 PM

trasz edited the summary of this revision. (Show Details)

trasz edited the summary of this revision. (Show Details)Sep 23 2020, 2:05 PM

Note in the commit message that 48->32 is for LP64, for ILP32 it seems to be 32->28 (but I could miscount).

This revision is now accepted and ready to land.Sep 23 2020, 3:05 PM

Closed by commit rS366201: Shrink struct sysent from 48 to 32 bytes (on LP64; on ILP32 its probably (authored by trasz). · Explain WhySep 27 2020, 6:14 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS366201: Shrink struct sysent from 48 to 32 bytes (on LP64; on ILP32 its probably.

Revision Contents
Changeset List

Path

Size

head/

sys/

sysent.h

6 lines

Diff 77573

View Options

Shrink sysent from 48 to 32 bytesClosedPublicActions