Page MenuHomeFreeBSD

atomic_common.h: Fix the volatile qualifier placement in atomic_load_ptr
ClosedPublic

Authored by jrtc27 on Sep 20 2020, 10:31 PM.
Tags
None
Referenced Files
F107462028: D26500.diff
Tue, Jan 14, 12:32 PM
Unknown Object (File)
Fri, Jan 10, 7:09 AM
Unknown Object (File)
Wed, Jan 1, 3:26 AM
Unknown Object (File)
Nov 25 2024, 2:14 PM
Unknown Object (File)
Oct 24 2024, 8:51 AM
Unknown Object (File)
Sep 24 2024, 9:06 AM
Unknown Object (File)
Sep 23 2024, 2:51 AM
Unknown Object (File)
Sep 19 2024, 10:10 AM
Subscribers

Details

Summary

This was broken in r357940 which introduced the __typeof use. We need
the volatile qualifier to be on the pointee not the pointer otherwise it
does nothing. This was found by mhorne in D26498, noticing there was a
problem (a spin loop condition was hoisted for RISC-V boot code) but not
the root cause of it.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33678
Build 30916: arc lint + arc unit