Page MenuHomeFreeBSD

atomic_common.h: Fix the volatile qualifier placement in atomic_load_ptr
ClosedPublic

Authored by jrtc27 on Sep 20 2020, 10:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 5, 11:18 AM
Unknown Object (File)
Sun, Feb 2, 2:02 AM
Unknown Object (File)
Thu, Jan 23, 10:27 PM
Unknown Object (File)
Wed, Jan 15, 12:06 AM
Unknown Object (File)
Tue, Jan 14, 11:54 PM
Unknown Object (File)
Jan 14 2025, 12:32 PM
Unknown Object (File)
Jan 10 2025, 7:09 AM
Unknown Object (File)
Jan 1 2025, 3:26 AM
Subscribers

Details

Summary

This was broken in r357940 which introduced the __typeof use. We need
the volatile qualifier to be on the pointee not the pointer otherwise it
does nothing. This was found by mhorne in D26498, noticing there was a
problem (a spin loop condition was hoisted for RISC-V boot code) but not
the root cause of it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable