Paths

Table of Contentst

RISC-V: fix some mismatched format specifiers
ClosedPublic
Actions

Authored by mhorne on Sep 4 2020, 12:24 AM.

Details

Reviewers

jhb
br

Group Reviewers

riscv

Commits

rS365455: RISC-V: fix some mismatched format specifiers

Summary

RISC-V has been built with -Wno-format, which is how these went undetected.
Address them now before re-enabling those warnings.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33390
Build 30690: arc lint + arc unit

Event Timeline

mhorne requested review of this revision.Sep 4 2020, 12:24 AM

mhorne created this revision.

Harbormaster completed remote builds in B33374: Diff 76631.Sep 4 2020, 12:24 AM

arichardson added a subscriber: arichardson.Sep 4 2020, 7:24 AM

arichardson added inline comments.

sys/riscv/riscv/db_disasm.c
419	Could also use %x since it's an int? How is this not triggering warnings with clang?
527	Same here?

mhorne added inline comments.Sep 4 2020, 1:44 PM

sys/riscv/riscv/db_disasm.c
419	Yeah, that is better. Looks like `-Wno-format` is passed when `MK_FORMAT_EXTENSIONS == "no"`, so that would be why clang hasn't complained. I'm enabling it in D26320.

Address @arichardson's comment. Fix one additional instance in a riscv-specific driver.

Harbormaster completed remote builds in B33390: Diff 76650.Sep 4 2020, 1:57 PM

mhorne edited the summary of this revision. (Show Details)Sep 4 2020, 2:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 8 2020, 1:21 PM

Closed by commit rS365455: RISC-V: fix some mismatched format specifiers (authored by mhorne). · Explain Why

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS365455: RISC-V: fix some mismatched format specifiers.

Herald added a subscriber: imp. · View Herald TranscriptSep 8 2020, 1:21 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

xilinx/

axidma.c

2 lines

riscv/

4 lines

8 lines

2 lines

4 lines

4 lines

Diff 76650

View Options

sys/dev/xilinx/axidma.c

View Options

sys/riscv/riscv/db_disasm.c

View Options

sys/riscv/riscv/intr_machdep.c

View Options

sys/riscv/riscv/pmap.c

View Options

sys/riscv/riscv/sbi.c

View Options

RISC-V: fix some mismatched format specifiersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 76650

sys/dev/xilinx/axidma.c

sys/riscv/riscv/db_disasm.c

sys/riscv/riscv/intr_machdep.c

sys/riscv/riscv/pmap.c

sys/riscv/riscv/sbi.c

sys/riscv/riscv/trap.c

RISC-V: fix some mismatched format specifiers
ClosedPublic
Actions

Revision Contents
Changeset List