Reduce Duplication in sys/*/include files

[pnagato_protonmail.com]

Summary

@imp Opening a diff for feedback/discussion

[pnagato_protonmail.com]

Added the duplication to a new file

i386_amd64.h2 KBDownload

[lwhsu]

Would it make more sense to create sys/x86/include/x86_ieeefp.h and include it in amd64/include/ieeefp.h and i386/include/ieeefp.h?

BTW, please consider submitting/updating patch with arc tool: https://wiki.freebsd.org/Phabricator

[pnagato_protonmail.com]

Move duplicated code under x86/include

[pnagato_protonmail.com]

@lwhsu Thank you, i moved the duplicated code under x86/include/x86_ieeefp.h and i was able to arc to update the diff.

[pnagato_protonmail.com]

Add new line and space after #include

[pnagato_protonmail.com]

Space after #include

[lwhsu]

@imp : ping, do you think this makes sense? It looks good to me but I'm not sure the convention is naming it x86_ieeefp.h or _ieeefp.h, I saw both under x86/include.

[imp]

I think this is fine

[lwhsu]

One final question, is the "Deprecated historical FPU control interface" comment also applicable to the remaining codes in amd64 and i386?

[lwhsu]

After checked these:

• https://cgit.freebsd.org/src/commit/?id=a50079b7ff232bbc45443ec0f1763fd449cea9a8
• https://www.freebsd.org/cgi/man.cgi?fpgetround

I've updated the differential at https://github.com/lwhsu/freebsd-src/commit/efdc084a247585588335beae9a0ef17fcff4c20e

Change summary:

• Add copyright header for x86/include/x86_ieeefp.h
• Restore "Deprecated historical FPU control interface" comments in {amd64,i386}/include/ieeefp.h as it is applicable to the remaining codes
• Restore the warning of {FP,SSE}*FLD and {FP,SSE}*OFF in amd64/include/ieeefp.h as there are still applicable codes.
• White space cleanup

@pnagato_protonmail.com: please let me know if those changes look good to you.

[pnagato_protonmail.com]

@lwhsu Looks good. Thank you for reviewing.