Page MenuHomeFreeBSD
Differential D26158

contrib/nvi: fix -w option
ClosedPublic
Actions

Authored by fernape on Aug 22 2020, 5:55 PM.
Tags
None
Referenced Files
F109034041: D26158.id77712.diff
Thu, Jan 30, 10:20 PM
Unknown Object (File)
Thu, Jan 23, 10:01 AM
Unknown Object (File)
Sun, Jan 12, 3:14 AM
Unknown Object (File)
Thu, Jan 2, 12:02 AM
Unknown Object (File)
Dec 30 2024, 6:11 PM
Unknown Object (File)
Dec 30 2024, 1:43 AM
Unknown Object (File)
Dec 29 2024, 2:05 PM
Unknown Object (File)
Dec 28 2024, 2:53 PM
View All 89 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
peter
arichardson
bapt
Commits
rG4365415046a3: Update nvi to 2.2.0-05ed8b9
rS366309: Update nvi to 2.2.0-05ed8b9
Summary

Reported in PR 241985

Compose the "window=%s" option as a CHAR_T to be processed properly in
opts_set

Test Plan

Before the patch, trying this:

$ vi -w 10

shows an error:

set: no wo0 option: 'set all' gives all option values
Press Enter to continue:

And vi launches with as many lines as to fill the terminal screen

------------ BEGINING OF SCREEN

~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
~
------------ END OF SCREEN

After the patch, thre is no error

$ vi -w 10

and the vi screen is limited to the specified amount of lines:

------------ BEGINING OF SCREEN

~
~
~
~
~
~
~
~
~
------------ END OF SCREEN

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 33107
Build 30476: arc lint + arc unit

Event Timeline

fernape created this revision.Aug 22 2020, 5:55 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptAug 22 2020, 5:55 PM
fernape requested review of this revision.Aug 22 2020, 5:55 PM
Harbormaster completed remote builds in B33107: Diff 76090.Aug 22 2020, 5:56 PM
fernape added a reviewer: peter.Aug 22 2020, 6:13 PM
fernape mentioned this in D26163: vi(1): Add URL to the vi/ex reference manual in the man page.Aug 23 2020, 11:05 AM
fernape added reviewers: arichardson, bapt.Sep 23 2020, 4:55 PM
fernape mentioned this in rS366148: vi(1): Add URL to the vi/ex reference manual in the man page.Sep 25 2020, 10:20 AM
fernape added a comment.Sep 27 2020, 6:11 PM

This one has been merged upstream

Should I withdraw this review?
What to do with the original PR?

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2020, 4:47 AM
Closed by commit rS366309: Update nvi to 2.2.0-05ed8b9 (authored by bapt). · Explain Why
This revision was automatically updated to reflect the committed changes.
bapt added a commit: rS366309: Update nvi to 2.2.0-05ed8b9.
bapt mentioned this in rGee3ebf390811: vi(1): Add URL to the vi/ex reference manual in the man page.Sep 22 2021, 10:33 AM
bapt added a commit: rG4365415046a3: Update nvi to 2.2.0-05ed8b9.

Revision Contents
Changeset List

PathSize
contrib/
nvi/
common/
8 lines

Diff 76090

View Options

contrib/nvi/common/main.c

Loading...