Page MenuHomeFreeBSD

[PowerPC] Move pmc_hook out of critical section
ClosedPublic

Authored by luporl on Aug 18 2020, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 2:02 PM
Unknown Object (File)
Tue, Jan 7, 11:05 AM
Unknown Object (File)
Tue, Jan 7, 11:05 AM
Unknown Object (File)
Tue, Jan 7, 11:05 AM
Unknown Object (File)
Tue, Jan 7, 10:23 AM
Unknown Object (File)
Thu, Dec 26, 1:47 PM
Unknown Object (File)
Mon, Dec 23, 3:20 PM
Unknown Object (File)
Dec 1 2024, 8:30 PM
Subscribers

Details

Summary

Calling pmc_hook inside a critical section may result in a panic.

This happens when the user callchain is fetched, because it uses pmap_map_user_ptr, that tries to get the (sleepable) pmap lock when the needed vsid is not found.

Judging by the implementation in other platforms, intr_irq_handler in kern/subr_intr.c and what pmc_hook do, it seems safe to move pmc_hook outside the critical section.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable