Fix -DBUILD_WITH_STRICT_TMPPATH dtrace builds

[arichardson]

Summary

Some of the scripts used for libdtrace invoke nawk instead of awk
(for example cddl/contrib/opensolaris/lib/libdtrace/common/mknames.sh).
When bootstrapping all tools, we get the nawk -> awk link while building
usr.bin/awk, but when linking/copying the dependencies from the host we
were only adding awk but not nawk.

This was silently generating invalid files when building libdtrace with
BUILD_WITH_STRICT_TMPPATH=1 since those scripts invoke nawk instead of
awk. In addition to adding the missing link this commit also adds
set -e to those scripts to catch errors like this in the future.

Obtained from: CheriBSD

[markj]

Seems fine to me, but can you see why we can't just use awk?

[emaste]

Was the issue just that it tried to invoke nawk but it didn't exist?

[arichardson]

In D26025#577359, @emaste wrote:

Was the issue just that it tried to invoke nawk but it didn't exist?

Yes and then it failed to produce correct output.

I guess I could also change it to use awk instead, but since I haven't audited the whole tree for uses of nawk, adding the nawk->awk link to WORLDTMP seems like the safer solution.

[emaste]

adding the nawk->awk link to WORLDTMP seems like the safer solution

Yeah, that's fine with me. A future step could be to make BUILD_WITH_STRICT_TMPPATH the default, then try to identify and remove unnecessary tools more broadly.

[arichardson]

In D26025#577391, @emaste wrote:

adding the nawk->awk link to WORLDTMP seems like the safer solution

Yeah, that's fine with me. A future step could be to make BUILD_WITH_STRICT_TMPPATH the default, then try to identify and remove unnecessary tools more broadly.

I would very much like to do that. It's already the default in CheriBSD and I originally set it to on-by-default when I first committed it upstream. However, it broke too many cases that I hadn't tested/wasn't able to test, so I switched the default to off again.
I'll try flipping the default again after the cross-build patches have landed, hopefully the remaining issues will be fixed by those patches.