Differential D25978

Add missing FreeBSD functions to -legacy when building on macOS/Linux
ClosedPublic
Actions

Authored by arichardson on Aug 6 2020, 6:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 27, 6:59 PM

	Unknown Object (File)
	Tue, Sep 24, 9:10 AM

	Unknown Object (File)
	Fri, Sep 20, 8:11 AM

	Unknown Object (File)
	Wed, Sep 18, 2:10 PM

	Unknown Object (File)
	Mon, Sep 16, 7:10 AM

	Unknown Object (File)
	Sat, Sep 14, 5:14 PM

	Unknown Object (File)
	Wed, Sep 11, 4:56 PM

	Unknown Object (File)
	Tue, Sep 10, 3:13 PM

Subscribers

Details

Reviewers

brooks
emaste
bdrewery
imp
jhb

Commits

rS364759: Add missing FreeBSD functions to -legacy when building on macOS/Linux

Summary

In most cases this simply builds the file from lib/libc for missing
functions (e.g. strlcpy on Linux etc.). In cases where this is not possible
I've added an implementation to tools/build/cross-build.

The fgetln.c/fgetwln.c/closefrom.c compatibility code was obtained from
https://gitlab.freedesktop.org/libbsd/libbsd, but I'm not sure it makes
sense to import it into to contrib just for these three bootstrap files.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32855
Build 30262: arc lint + arc unit

Event Timeline

arichardson created this revision.Aug 6 2020, 6:02 PM

Herald added a subscriber: jonathan. · View Herald TranscriptAug 6 2020, 6:02 PM

arichardson requested review of this revision.Aug 6 2020, 6:02 PM

Harbormaster completed remote builds in B32818: Diff 75515.Aug 6 2020, 6:02 PM

I don't have a strong opinion on vendoring those libbsd files.

fgetln is an atrocity, but unfortunately a widely used one. :(

This revision is now accepted and ready to land.Aug 6 2020, 8:39 PM

minor cleanup

This revision now requires review to proceed.Aug 7 2020, 1:29 PM

Harbormaster completed remote builds in B32839: Diff 75558.Aug 7 2020, 1:29 PM

arichardson added a child revision: D16767: Add a tools/build/make.py script that bootstraps bmake and then runs the build.Aug 7 2020, 3:30 PM

fix linux builds

Harbormaster completed remote builds in B32855: Diff 75582.Aug 7 2020, 5:24 PM

brooks accepted this revision.Aug 10 2020, 5:30 PM

This revision is now accepted and ready to land.Aug 10 2020, 5:30 PM

drop unrelated change

This revision now requires review to proceed.Aug 11 2020, 2:40 PM

Harbormaster completed remote builds in B32908: Diff 75673.Aug 11 2020, 2:40 PM

brooks accepted this revision.Aug 11 2020, 8:44 PM

This revision is now accepted and ready to land.Aug 11 2020, 8:44 PM

rebase, move some includes to also be copied for !crossbuild (should hopefully fix cirrus CI)

This revision now requires review to proceed.Aug 13 2020, 3:06 PM

Harbormaster completed remote builds in B32975: Diff 75790.Aug 13 2020, 3:06 PM

brooks accepted this revision.Aug 13 2020, 10:06 PM

This revision is now accepted and ready to land.Aug 13 2020, 10:06 PM

Closed by commit rS364759: Add missing FreeBSD functions to -legacy when building on macOS/Linux (authored by arichardson). · Explain WhyAug 25 2020, 1:23 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS364759: Add missing FreeBSD functions to -legacy when building on macOS/Linux.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

4 lines

libcapsicum/

capsicum_helpers.h

12 lines

share/

mk/

9 lines

tools/

build/

195 lines

cross-build/

capsicum_stubs.c

59 lines

192 lines

55 lines

fgetln_fallback.c

84 lines

fgetwln_fallback.c

93 lines

38 lines

52 lines

libc-bootstrap/

3 lines

15 lines

3 lines

mk/

68 lines

Makefile.boot.pre

12 lines

3 lines

1 line

Diff 75582

lib/libc/gen/arc4random.h

Loading...

lib/libcapsicum/capsicum_helpers.h

Loading...

share/mk/bsd.links.mk

Loading...

tools/build/Makefile

Loading...

tools/build/cross-build/capsicum_stubs.c

Loading...

tools/build/cross-build/closefrom.c

Loading...

tools/build/cross-build/fake_sysctl.c

Loading...

tools/build/cross-build/fgetln_fallback.c

Loading...

tools/build/cross-build/fgetwln_fallback.c

Loading...

tools/build/cross-build/local-link.h

Loading...

tools/build/cross-build/progname.c

Loading...

tools/build/libc-bootstrap/libc_private.h

Loading...

tools/build/libc-bootstrap/namespace.h

Loading...

tools/build/libc-bootstrap/un-namespace.h

Loading...

tools/build/mk/Makefile.boot

Loading...

tools/build/mk/Makefile.boot.pre

Loading...

tools/build/mk/bsd.lib.mk

Loading...

tools/build/mk/bsd.prog.mk

Loading...