Page MenuHomeFreeBSD

Preserve ASLR vm_map flags across fork.
ClosedPublic

Authored by brooks on Aug 5 2020, 7:50 PM.
Tags
None
Referenced Files
F112092104: D25966.id75448.diff
Wed, Mar 12, 4:49 PM
Unknown Object (File)
Sat, Mar 8, 9:21 AM
Unknown Object (File)
Mon, Mar 3, 9:13 PM
Unknown Object (File)
Jan 7 2025, 10:12 AM
Unknown Object (File)
Dec 14 2024, 4:37 PM
Unknown Object (File)
Dec 1 2024, 5:44 AM
Unknown Object (File)
Nov 27 2024, 1:36 PM
Unknown Object (File)
Nov 19 2024, 3:39 PM
Subscribers

Details

Summary

In the most common case (fork+execve) this doesn't matter, but further
attempts to apply entropy would fail in (e.g.) a pre-fork server.

Reported by: Alfredo Mazzinghi

Test Plan

A variant of this patch preserving an additional local flag
works in CheriBSD.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks requested review of this revision.Aug 5 2020, 7:50 PM
brooks created this revision.
sys/vm/vm_map.c
4102 ↗(On Diff #75448)

() are excessive.
Also I suggest to move the line right after new_map assignment (line 4098), no need for blank lines around.

sys/vm/vm_map.h
226 ↗(On Diff #75448)

It is single-use symbol, it is easier to read code when flags are listed explicitly in vmspace_fork().

  • Relocate flags assignment and don't use a variable.
This revision is now accepted and ready to land.Aug 5 2020, 9:11 PM
This revision was automatically updated to reflect the committed changes.