Page MenuHomeFreeBSD
Differential D25302

Add `kern.features.witness`
ClosedPublic
Actions

Authored by ngie on Jun 16 2020, 9:16 PM.
Tags
None
Referenced Files
F102982279: D25302.diff
Tue, Nov 19, 11:19 AM
Unknown Object (File)
Sat, Nov 16, 6:29 PM
Unknown Object (File)
Thu, Nov 7, 8:27 AM
Unknown Object (File)
Oct 3 2024, 11:05 AM
Unknown Object (File)
Oct 3 2024, 9:58 AM
Unknown Object (File)
Oct 1 2024, 3:21 PM
Unknown Object (File)
Sep 30 2024, 4:26 AM
Unknown Object (File)
Sep 28 2024, 2:33 PM
View All 81 Files
Subscribers
imp
jhb

Details

Reviewers
cem
bdrewery
darrick.freebsd_gmail.com
Commits
rG52122fa0968f: Add `kern.features.witness`
rS362591: Add `kern.features.witness`
Summary

Adding kern.features.witness helps expose whether or not the kernel has
options WITNESS enabled, so the feature_present(3) API can be used
to query whether or not witness(9) is built into the kernel.

This support is helpful with userspace applications (generally speaking,
tests), as it can be queried to determine whether or not tests related
to WITNESS should be run.

MFC after: 1 week
Sponsored by: DellEMC Isilon

Test Plan

Confirmed that the feature worked with a kernel with WITNESS enabled (GENERIC) and disabled (GENERIC-NODEBUG).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31747
Build 29313: arc lint + arc unit

Event Timeline

ngie created this revision.Jun 16 2020, 9:16 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 16 2020, 9:16 PM
ngie requested review of this revision.Jun 16 2020, 9:16 PM
Harbormaster completed remote builds in B31747: Diff 73193.Jun 16 2020, 9:16 PM
ngie edited the test plan for this revision. (Show Details)Jun 16 2020, 9:17 PM
ngie added a reviewer: darrick.freebsd_gmail.com.
ngie retitled this revision from Add kern.features.witness to Add `kern.features.witness`.
ngie edited the summary of this revision. (Show Details)
ngie edited the summary of this revision. (Show Details)
cem accepted this revision.Jun 16 2020, 9:19 PM
This revision is now accepted and ready to land.Jun 16 2020, 9:19 PM
ngie updated this revision to Diff 73196.Jun 16 2020, 9:20 PM

The FEATURE call should be moved down.

This revision now requires review to proceed.Jun 16 2020, 9:20 PM
Harbormaster completed remote builds in B31748: Diff 73196.Jun 16 2020, 9:20 PM
darrick.freebsd_gmail.com added a comment.Jun 23 2020, 4:25 PM

lgtm

ngie edited the test plan for this revision. (Show Details)Jun 24 2020, 6:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 24 2020, 6:51 PM
Closed by commit rS362591: Add `kern.features.witness` (authored by ngie). · Explain Why
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rS362591: Add `kern.features.witness`.
ngie added a commit: rG52122fa0968f: Add `kern.features.witness`.Apr 11 2022, 2:08 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 73193

View Options

sys/kern/subr_witness.c

Loading...