Paths

Table of Contentst

Differential D25084

bridge tests: Avoid building a switching loop
ClosedPublic
Actions

Authored by kp on May 31 2020, 7:20 PM.

Details

Reviewers

melifaro

Group Reviewers

network

Commits

rGfd5828b62bdb: bridge tests: Avoid building a switching loop
rS361701: bridge tests: Avoid building a switching loop

Summary

Enable STP before bringing the bridges up. This avoids a switching loop,
which has a tendency to drown out progress in userspace processes,
especially on single-core systems.

Only check that we have indeed shut down one of the looped interfaces

PR: 246448

Diff Detail

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	tests/sys/net/if_bridge_test.sh:	CHMOD1	Invalid Executable

Unit

No Test Coverage

Build Status

Buildable 31410
Build 29032: arc lint + arc unit

Event Timeline

kp created this revision.May 31 2020, 7:20 PM

Herald added subscribers: melifaro, ae. · View Herald TranscriptMay 31 2020, 7:20 PM

Harbormaster completed remote builds in B31410: Diff 72483.May 31 2020, 7:20 PM

kp requested review of this revision.May 31 2020, 7:20 PM

lwhsu added a subscriber: lwhsu.Jun 1 2020, 3:11 PM

We no longer require jq

Harbormaster completed remote builds in B31427: Diff 72534.Jun 1 2020, 3:39 PM

LGTM.

Minor nit: any chance jails a and b can be named bridge_stp_a and bridge_stp_b to avoid potential clashes with other tests?

This revision is now accepted and ready to land.Jun 1 2020, 3:51 PM

This revision was landed with ongoing or failed builds.Jun 1 2020, 7:26 PM

Closed by commit rS361701: bridge tests: Avoid building a switching loop (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rS361701: bridge tests: Avoid building a switching loop.

Herald added a subscriber: imp. · View Herald TranscriptJun 1 2020, 7:26 PM

In D25084#552683, @melifaro wrote:

Minor nit: any chance jails a and b can be named bridge_stp_a and bridge_stp_b to avoid potential clashes with other tests?

Yeah, but that should be its own commit.

kp added a commit: rGfd5828b62bdb: bridge tests: Avoid building a switching loop.Mar 2 2021, 3:19 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

net/

if_bridge_test.sh

16 lines

Diff 72483

View Options

tests/sys/net/if_bridge_test.sh

bridge tests: Avoid building a switching loopClosedPublicActions