Differential D24977

Make NFS address selection use fib4_lookup().
ClosedPublic
Actions

Authored by melifaro on May 23 2020, 5:12 PM.

Details

Reviewers

rmacklem

Group Reviewers

network

Commits

rS361575: Make NFS address selection use fib4_lookup().

Summary

fib4_lookup_nh_ represents pre-epoch generation of fib api,
providing less guarantees over pointer validness and requiring
on-stack data copying.
Switch call to use new fib4_lookup(), allowing to eventually
deprecate old api.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31260
Build 28906: arc lint + arc unit

Event Timeline

melifaro created this revision.May 23 2020, 5:12 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2020, 5:12 PM

melifaro requested review of this revision.May 23 2020, 5:12 PM

Harbormaster completed remote builds in B31260: Diff 72168.May 23 2020, 5:12 PM

Sorry, I know nothing about this stuff, so I can't review it.
(This code has been written by others, possibly long ago.)

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2020, 7:35 AM

Closed by commit rS361575: Make NFS address selection use fib4_lookup(). (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS361575: Make NFS address selection use fib4_lookup()..

Revision Contents
Changeset List

Path

Size

sys/

fs/

nfsclient/

nfs_clport.c

18 lines

Diff 72168

View Options

sys/fs/nfsclient/nfs_clport.c

Make NFS address selection use fib4_lookup().ClosedPublicActions