Page MenuHomeFreeBSD
Differential D24249

bridge: Change lists to CK_LIST as a peparation for epochification
ClosedPublic
Actions

Authored by kp on Apr 1 2020, 2:26 PM.
Tags
None
Referenced Files
F102434288: D24249.diff
Tue, Nov 12, 5:35 AM
Unknown Object (File)
Sun, Oct 20, 8:50 PM
Unknown Object (File)
Sun, Oct 20, 8:50 PM
Unknown Object (File)
Sun, Oct 20, 8:49 PM
Unknown Object (File)
Sun, Oct 20, 8:49 PM
Unknown Object (File)
Sun, Oct 20, 8:33 PM
Unknown Object (File)
Oct 2 2024, 6:21 PM
Unknown Object (File)
Oct 2 2024, 10:55 AM
View All Files
Subscribers
ae
afedorov
crest_bultmann.eu
imp
melifaro
olivier

Details

Reviewers
emaste
philip
ae
Group Reviewers
network
Commits
rS359641: bridge: Change lists to CK_LIST as a peparation for epochification
Summary

Prepare the ground for a rework of the bridge locking approach. We will
use an epoch-based approach in the datapath and making it safe to
iterate over the interface, span and rtnode lists without holding the
BRIDGE_LOCK. Replace the relevant lists by their ConcurrencyKit
equivalents.

No functional change in this commit.

Sponsored by: The FreeBSD Foundation

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30228
Build 28013: arc lint + arc unit

Event Timeline

kp created this revision.Apr 1 2020, 2:26 PM
Herald added subscribers: melifaro, ae. · View Herald TranscriptApr 1 2020, 2:26 PM
Harbormaster completed remote builds in B30228: Diff 70090.Apr 1 2020, 2:26 PM
kp added a child revision: D24250: bridge: epoch-ification.Apr 1 2020, 2:27 PM
afedorov added a subscriber: afedorov.Apr 1 2020, 4:35 PM
emaste added inline comments.Apr 1 2020, 9:35 PM
sys/net/if_bridge.c
1088

> 80 cols?

philip added inline comments.Apr 2 2020, 2:15 AM
sys/net/if_bridge.c
280

Does this belong in this review? It doesn't appear to be referenced by other changes in this diff.

kp updated this revision to Diff 70109.Apr 2 2020, 8:24 AM

Fix style issue and remove stray epoch_ctx.

Harbormaster completed remote builds in B30239: Diff 70109.Apr 2 2020, 8:24 AM
kp marked 2 inline comments as done.Apr 2 2020, 8:25 AM
kp added inline comments.
sys/net/if_bridge.c
280

It does not. I've removed it.

ae accepted this revision.Apr 2 2020, 8:40 AM
This revision is now accepted and ready to land.Apr 2 2020, 8:40 AM
crest_bultmann.eu added a subscriber: crest_bultmann.eu.Apr 2 2020, 10:02 AM
emaste added a comment.Apr 2 2020, 11:34 PM

OK with me

emaste accepted this revision.Apr 4 2020, 5:41 PM
Closed by commit rS359641: bridge: Change lists to CK_LIST as a peparation for epochification (authored by kp). · Explain WhyApr 5 2020, 5:16 PM
This revision was automatically updated to reflect the committed changes.
kp marked an inline comment as done.
kp added a commit: rS359641: bridge: Change lists to CK_LIST as a peparation for epochification.
Herald added a subscriber: imp. · View Herald TranscriptApr 5 2020, 5:16 PM
olivier added a subscriber: olivier.Apr 6 2020, 12:53 PM

Here are my result:

x r359647 in bridge mode: inet 4 packets forwarded per second
+ r359647 with D24250 in bridge mode: inet 4 packets forwarded per second
+--------------------------------------------------------------------------+
|xx                                                                      + |
|xx                                                                 +  + ++|
|A|                                                                        |
|                                                                     |_AM||
+--------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   5       3314595       3582601       3450403       3448858     99435.922
+   5      22726995      24346441      23963008      23715416     617156.45
Difference at 95.0% confidence
        2.02666e+07 +/- 644666
        587.631% +/- 27.5422%
        (Student's t, pooled s = 442024)

Revision Contents
Changeset List

PathSize
sys/
net/
130 lines

Diff 70090

View Options

sys/net/if_bridge.c

Loading...