Page MenuHomeFreeBSD
Differential D24173

pmc: Add include path for libpmcstat as it is an internallib
ClosedPublic
Actions

Authored by manu on Mar 24 2020, 10:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 23, 6:48 AM
Unknown Object (File)
Tue, Apr 22, 11:57 PM
Unknown Object (File)
Tue, Apr 22, 9:35 PM
Unknown Object (File)
Sun, Apr 20, 12:22 PM
Unknown Object (File)
Sun, Apr 20, 11:58 AM
Unknown Object (File)
Wed, Apr 16, 2:07 PM
Unknown Object (File)
Mar 16 2025, 12:43 AM
Unknown Object (File)
Mar 13 2025, 1:45 PM
View All 72 Files
Subscribers
imp

Details

Reviewers
bapt
emaste
Commits
rS359292: pmc: Add include path for libpmcstat as it is an internallib

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu created this revision.Mar 24 2020, 10:33 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 24 2020, 10:33 AM
bapt accepted this revision.Mar 24 2020, 1:46 PM
This revision is now accepted and ready to land.Mar 24 2020, 1:46 PM
emaste added a comment.Mar 24 2020, 6:40 PM

does this mean we can't automatically prevent header installation when INTERNALLIB?

Closed by commit rS359292: pmc: Add include path for libpmcstat as it is an internallib (authored by manu). · Explain WhyMar 25 2020, 1:32 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rS359292: pmc: Add include path for libpmcstat as it is an internallib.
manu added a comment.Mar 25 2020, 1:33 AM
In D24173#531679, @emaste wrote:

does this mean we can't automatically prevent header installation when INTERNALLIB?

We can, I need to re-apply r359267.
This was needed as the tools used the installed path for including pmcstat.h

Revision Contents
Changeset List

PathSize
lib/
libpmc/
3 lines
libpmcstat/
4 lines
usr.sbin/
pmc/
1 line
pmcstat/
1 line

Diff 69821

View Options

lib/libpmc/Makefile

Loading...
View Options

lib/libpmcstat/Makefile

Loading...
View Options

usr.sbin/pmc/Makefile

Loading...
View Options

usr.sbin/pmcstat/Makefile

Loading...