sshd: Warn about missing ssh-keygen only when necessary
ClosedPublic
Actions

Authored by 0mp on Mar 1 2020, 10:41 PM.

Details

Reviewers

emaste
dteske

Commits

rS363553: MFC 359973:
rS359973: sshd: Warn about missing ssh-keygen only when necessary

Summary

sshd: Warn about missing ssh-keygen only when necessary

The sshd service is using ssh-keygen to generate missing SSH keys. If
ssh-keygen is missing, it prints the following message:

> /etc/rc.d/sshd: WARNING: /usr/bin/ssh-keygen does not exist.

It makes sense when the key is not generated yet and cannot be created because
ssh-keygen is missing.

The problem is that even if the key is present on the host, the sshd service
would still warn about missing ssh-keygen (even though it does not need it).

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244492

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29707
Build 27556: arc lint + arc unit

Event Timeline

0mp created this revision.Mar 1 2020, 10:41 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 1 2020, 10:41 PM

Harbormaster completed remote builds in B29707: Diff 69039.Mar 1 2020, 10:41 PM

0mp edited the summary of this revision. (Show Details)Mar 1 2020, 10:42 PM

MAINTAINERS says openssh is maintained by des, who accepts reviews via email only (no phabricator).

In D23911#525991, @jilles wrote:

MAINTAINERS says openssh is maintained by des, who accepts reviews via email only (no phabricator).

I'll message him. Thanks for the remainder about the MAINTAINERS file.

In D23911#526012, @0mp wrote:

In D23911#525991, @jilles wrote:

MAINTAINERS says openssh is maintained by des, who accepts reviews via email only (no phabricator).

I'll message him. Thanks for the remainder about the MAINTAINERS file.