Page MenuHomeFreeBSD
Differential D23477

netgraph: If queue is full, don't enqueue in ng_source_rcvdata()
ClosedPublic
Actions

Authored by nc on Feb 3 2020, 4:40 AM.
Tags
None
Referenced Files
F98899435: D23477.diff
Sat, Oct 5, 5:23 AM
Unknown Object (File)
Thu, Oct 3, 9:59 PM
Unknown Object (File)
Tue, Oct 1, 3:58 PM
Unknown Object (File)
Mon, Sep 30, 6:00 PM
Unknown Object (File)
Thu, Sep 26, 3:30 PM
Unknown Object (File)
Mon, Sep 23, 11:31 AM
Unknown Object (File)
Tue, Sep 17, 5:50 PM
Unknown Object (File)
Mon, Sep 9, 4:39 AM
View All 84 Files
Subscribers
donner
imp
kp
melifaro
Contributor Reviews (src)

Details

Reviewers
donner
Commits
rG3da0d11afe08: netgraph/ng_source: If queue is full, don't enqueue
rG16ed32cc4b02: netgraph/ng_source: If queue is full, don't enqueue
rGd7dd28bb09fa: netgraph/ng_source: If queue is full, don't enqueue
Summary

If queue is full, don't enqueue in ng_source_rcvdata()

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

nc created this revision.Feb 3 2020, 4:40 AM
Herald added subscribers: Contributor Reviews (src), donner, imp. · View Herald TranscriptFeb 3 2020, 4:40 AM
donner added a reviewer: donner.Feb 3 2020, 7:24 AM

Please let me verify, that this change does not break D21968.

donner added inline comments.Feb 3 2020, 7:32 AM
sys/netgraph/ng_source.c
287

This comment should be removed.

donner added inline comments.Feb 3 2020, 7:43 AM
sys/netgraph/ng_source.c
571

_IF_xxx are unlocked, while IF_xxx enclose the operation in the queue mutex.

Because all calls in the module use the unlocked version, there is no need to make an extra effort here.

OTOH, even if the other calls would use locking, this call did not need any locking because it's read only and the possible damage in the case of a race condition is limited.

So I'm fine with it.

donner requested changes to this revision.Feb 3 2020, 7:45 AM

There are no interactions with the other open review.

To proceed, please remove the comment in https://reviews.freebsd.org/D23477#inline-145966

This revision now requires changes to proceed.Feb 3 2020, 7:45 AM
nc updated this revision to Diff 67696.Feb 3 2020, 1:51 PM

Sure, removed the comment

nc marked an inline comment as done.Feb 3 2020, 1:53 PM
donner added inline comments.Feb 3 2020, 3:26 PM
sys/netgraph/ng_source.c
573

I'd like to have an error value other than 0.
How about ENOBUFS or similar?

nc updated this revision to Diff 67740.Feb 3 2020, 8:11 PM

Sure, done so.

donner accepted this revision.Feb 3 2020, 8:31 PM
This revision is now accepted and ready to land.Feb 3 2020, 8:31 PM
kp added a subscriber: kp.Jan 23 2021, 2:49 PM

Approved by: kp (mentor)

Herald added a subscriber: melifaro. · View Herald TranscriptJan 23 2021, 2:49 PM
Closed by commit rGd7dd28bb09fa: netgraph/ng_source: If queue is full, don't enqueue (authored by donner). · Explain WhyJan 23 2021, 6:03 PM
This revision was automatically updated to reflect the committed changes.
Lutz Donnerhacke <donner@FreeBSD.org> added a commit: rGd7dd28bb09fa: netgraph/ng_source: If queue is full, don't enqueue.
donner added a commit: rG16ed32cc4b02: netgraph/ng_source: If queue is full, don't enqueue.May 9 2021, 1:43 PM
donner added a commit: rG3da0d11afe08: netgraph/ng_source: If queue is full, don't enqueue.May 9 2021, 1:46 PM

Revision Contents
Changeset List

PathSize
sys/
netgraph/
9 lines

Diff 67696

View Options

sys/netgraph/ng_source.c

Loading...