Page MenuHomeFreeBSD

Merge commit d3aeac8e2 from llvm git (by Justin Hibbits)
ClosedPublic

Authored by dim on Dec 23 2019, 7:16 PM.
Tags
None
Referenced Files
F114788104: D22913.diff
Wed, Apr 16, 9:39 PM
Unknown Object (File)
Mon, Apr 14, 9:07 AM
Unknown Object (File)
Mon, Apr 14, 5:16 AM
Unknown Object (File)
Mon, Apr 14, 12:36 AM
Unknown Object (File)
Sun, Apr 13, 11:12 PM
Unknown Object (File)
Mon, Apr 7, 4:43 AM
Unknown Object (File)
Feb 22 2025, 12:58 AM
Unknown Object (File)
Feb 18 2025, 11:58 AM
Subscribers

Details

Summary
[PowerPC] Only use PLT annotations if using PIC relocation model

Summary:

The default static (non-PIC, non-PIE) model for 32-bit powerpc does
not use @PLT annotations and relocations in GCC.  LLVM shouldn't use
@PLT annotations either, because it breaks secure-PLT linking with
(some versions of?) GNU LD.

Update the available-externally.ll test to reflect that default mode
should be the same as the static relocation, by using the same check
prefix.

Reviewed by:    sfertile
Differential Revision: https://reviews.llvm.org/D70570

This diff needed some fuzz to apply, double-checking it via this review.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28292
Build 26402: arc lint + arc unit

Event Timeline

contrib/llvm-project/llvm/lib/Target/PowerPC/PPCISelLowering.cpp
4960

The original diff I had created, before rebasing on the giant refactor used TM.getRelocationModel(). I think this should still work, though.

This revision is now accepted and ready to land.Dec 23 2019, 10:30 PM