Add support for generating release images using GPT for ARM
ClosedPublic
Actions

Authored by diizzy on Nov 24 2019, 2:03 PM.

Details

Reviewers

Commits

Summary

This adds support for generating GPT images for ARM images

Test Plan

Tested on PINE64 (Pine Microsystems Inc.) ROCKPro64, using r354972 by Jesper Monsted

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

release/tools/arm.subr
80 ↗	(On Diff #64818)	you need to create gpt partition for the gpt scheme
220 ↗	(On Diff #64818)	And mount the gpt part here.

Switch to using GPT everywhere instead of using BSD slices

Use "efi" as label and boot/efi instead of boot/msdos

This revision is now accepted and ready to land.Nov 27 2019, 4:29 PM

release/tools/arm.subr
195 ↗	(On Diff #64945)	Why not use the UFS label both places?
197 ↗	(On Diff #64945)	The standard is just /boot/efi now
203 ↗	(On Diff #64945)	Ditto here. Mount on /boot/efi... likely need to correct other scripts... I know uboot wasn't always efi, but we have transitioned These kids seem kinda silly just to get
231 ↗	(On Diff #64945)	Here and elsewhere: we have a lot of ifs just to change the partition names..

release/tools/arm.subr
195 ↗	(On Diff #64945)	As far as I can tell GPT labels are preferred over UFS when using GPT as a partitioning scheme?
197 ↗	(On Diff #64945)	Not sure what you want me to do here
203 ↗	(On Diff #64945)	manu@ said on irc that was going to fix MBR in a separate commit
231 ↗	(On Diff #64945)	I tried to keep the original script as unaltered as possible and I'm not aware of a better way.

imp added inline comments.Dec 3 2019, 6:59 PM

release/tools/arm.subr
70 ↗	(On Diff #64945)	we should label the dos partitions the same.
72 ↗	(On Diff #64945)	same here.
195 ↗	(On Diff #64945)	It is? That's news to me.
197 ↗	(On Diff #64945)	Yea, I thought we were mounting /boot/efi/msdosfs, so n/m.
231 ↗	(On Diff #64945)	Set dospart= and ufspart= above and then use these down here.

release/tools/arm.subr
195 ↗	(On Diff #64945)	bsdinstall sets GPT labels if labels are set however they are not utilized in fstab (hardset), ZFS installs uses also sets GPT labels (as no other label types are supported afaik) which is why I think we should probably adopt it here too for consistency?