add deprecation warning to amd
ClosedPublic
Actions

Authored by emaste on Nov 20 2019, 7:37 PM.

Details

Reviewers

rgrimes
trasz
kevans
cy
brooks

Commits

rS354998: amd: add deprecation warning on program startup

Summary

The man page has claimed that (built-in) amd is obsolete. Add a warning emitted by amd itself on startup as well.

% usr.sbin/amd/amd/obj/amd              
Nov 20 14:37:34 unknown amd[-1]/warn:  built-in amd in FreeBSD is deprecated
Amd configuration file (/etc/amd.conf): No such file or directory

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Nov 20 2019, 7:37 PM

emaste added a reviewer: cy.

We should probably add the more specific- "deprecated and will be removed before FreeBSD 13" both here and the man page.

extend warning as suggested by @kevans

update man page too

LGTM

This revision is now accepted and ready to land.Nov 20 2019, 7:47 PM

kevans accepted this revision.Nov 20 2019, 7:47 PM

rgrimes accepted this revision.Nov 21 2019, 1:25 AM

I will commit the man page separately and MFC it in short order; I will also update it to mention that amd is available from ports (if e.g. someone doesn't want to change their existing config for some reason)

trasz accepted this revision.Nov 22 2019, 7:56 AM

Closed by commit rS354998: amd: add deprecation warning on program startup (authored by emaste). · Explain WhyNov 22 2019, 3:04 PM

This revision was automatically updated to reflect the committed changes.

emaste mentioned this in rS354997: add deprecation notice to amd man page.

emaste added a commit: rS354998: amd: add deprecation warning on program startup.

Herald added a subscriber: imp. · View Herald TranscriptNov 22 2019, 3:06 PM