libclang_rt: enable on powerpc*

[pkubaj]

Summary

Enable on powerpc64 and in lib/libclang_rt/Makefile change MACHINE_CPUARCH to MACHINE_ARCH because on powerpc64 MACHINE_ARCH==MACHINE_CPUARCH so the 32-bit library overwrites 64-bit library during installworld.

This patch doesn't enable any other libclang_rt libraries because they need to be separately ported.

I have verified that games/julius (which fails on powerpc64 elfv2 without this change because of no libclang_rt profiling library) builds.

Test Plan

Ship it, test on powerpc and powerpcspe

[pkubaj]

Also add new libraries to tools/build/mk/OptionalObsoleteFiles.inc.

[imp]

lib/Makefile

163

This enables it for 32 bit powerpc. Is that intended?

[pkubaj]

lib/Makefile

163

Yes, the title is wrong, the point is to enable it on all powerpc architectures.

[jhibbits]

lib/libclang_rt/Makefile.inc

11

Is this supposed to be a different change? powerpc isn't amd64.

[pkubaj]

lib/libclang_rt/Makefile.inc

11

No, it's supposed to be here. The reason is that MACHINE_CPUARCH on both powerpc and powerpc64 are the same (powerpc). This means that 64-bit and 32-bit library will have the same name and during installworld 32-bit library will overwrite the 64-bit one. Changing to MACHINE_ARCH will mean libraries will have different names.

[jhibbits]

lib/libclang_rt/Makefile.inc

11

Oh right, I don't know what I was thinking when I read that.

[dim]

LGTM.

[linimon]

This is simply above my pay-grade.

[pkubaj]

In D22425#491434, @linimon wrote:

This is simply above my pay-grade.

I need a mentor approval to commit it, so either you or mat or tcberner approve of it as well, or some src committer will have to commit on their own :) games/julius might seem not very useful, but lack of patch also breaks math/suitesparse, which makes 422 other ports skipped, so I imagine this is pretty important.

[linimon]

either you or mat or tcberner approve of it as well, or some src committer will have to commit on their own

You need a src committer to approve in any case. IIUC mentorship doesn't cross repository boundaries.

A quick check shows that none of the 3 of us have src bits.

[jhibbits]

My understanding is you need both mentor approval and src approval. Consider it src approved by me.

[dim]

@pkubaj if you can't commit it, I will be happy to do so.

[pkubaj]

In D22425#491696, @dim wrote:

@pkubaj if you can't commit it, I will be happy to do so.

I technically can, but my mentors will be angry :)

If you can commit it, please do.