ping: move in_cksum() to a separate source file
ClosedPublic
Actions

Authored by jansucan on Aug 16 2019, 7:20 AM.

Details

Reviewers

asomers

Commits

rS351171: ping: Move in_cksum() to a separate source file

Summary

Move in_cksum() to a separate source file

This is a preparation step for adding ATF tests of in_cksum(), which
has been modified to operate on unaligned data. ping.o cannot be
linked to the test executable because both of them contain 'main'
symbol.

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jansucan created this revision.Aug 16 2019, 7:20 AM

Harbormaster completed remote builds in B25910: Diff 60872.Aug 16 2019, 7:20 AM

I didn't put any copyright notice in utils.c because I didn't know what part of the copyright information to take from ping.c. Could you please help me with this?

In D21288#462858, @sucanjan_gmail.com wrote:

I didn't put any copyright notice in utils.c because I didn't know what part of the copyright information to take from ping.c. Could you please help me with this?

A safe bet is to use the whole copyright notice from ping.c.

As Ryan said, utils.c needs a copyright header. it also needs a $FreeBSD$ keyword.

This revision now requires changes to proceed.Aug 17 2019, 2:41 PM

jansucan retitled this revision from ping6: move in_cksum() to a separate source file to ping: move in_cksum() to a separate source file.Aug 17 2019, 3:14 PM

Use copyright information and ID from ping.c in utils.c.

Harbormaster completed remote builds in B25935: Diff 60945.Aug 17 2019, 3:16 PM

asomers accepted this revision.Aug 17 2019, 3:23 PM

This revision is now accepted and ready to land.Aug 17 2019, 3:23 PM

Closed by commit rS351171: ping: Move in_cksum() to a separate source file (authored by asomers). · Explain WhyAug 17 2019, 3:25 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS351171: ping: Move in_cksum() to a separate source file.

Herald added a subscriber: imp. · View Herald TranscriptAug 17 2019, 3:25 PM

asomers mentioned this in rS352357: MFC r350994, r350998, r351030, r351033, r351171, r351223, r351226, r351424.Sep 15 2019, 4:53 PM