ping6: Consistently use the byteorder functions in the correct direction
ClosedPublic
Actions

Authored by jansucan on Aug 12 2019, 7:03 AM.

Details

Reviewers

Commits

rS352232: MFC r350993, r350997, r351079-r351080, r351082, r351090, r351101-r351102
rS350993: Consistently use the byteorder functions in the correct direction

Summary

Consistently use the byteorder functions in the correct direction

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google, inc. (Google Summer of Code 2019)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jansucan created this revision.Aug 12 2019, 7:03 AM

Harbormaster completed remote builds in B25792: Diff 60662.Aug 12 2019, 7:03 AM

jansucan mentioned this in D21217: ping6: Fix alignment errors.Aug 12 2019, 11:03 AM

The description of this review isn't really correct. Since ntohs and htons have identical effects, you aren't making any change to the endianness of the sequence number on the wire. The change is more stylistic, really.

What should be the correct description?

Maybe something like "consistently use the byteorder functions in the correct direction"?

jansucan retitled this revision from ping6: Fix endianness of a sequence number in a packet to send to ping6: Consistently use the byteorder functions in the correct direction.Aug 13 2019, 7:23 AM

jansucan edited the summary of this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Aug 13 2019, 4:22 PM

Closed by commit rS350993: Consistently use the byteorder functions in the correct direction (authored by asomers). · Explain Why

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS350993: Consistently use the byteorder functions in the correct direction.

Herald added a subscriber: imp. · View Herald TranscriptAug 13 2019, 4:22 PM

asomers added a commit: rS352232: MFC r350993, r350997, r351079-r351080, r351082, r351090, r351101-r351102.Sep 11 2019, 8:13 PM