Page MenuHomeFreeBSD

Linuxulator: complete LOCAL_PEERCRED support.
ClosedPublic

Authored by dchagin on May 26 2019, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 10 2024, 10:48 AM
Unknown Object (File)
Nov 30 2024, 5:22 PM
Unknown Object (File)
Nov 30 2024, 5:22 PM
Unknown Object (File)
Nov 30 2024, 5:22 PM
Unknown Object (File)
Nov 30 2024, 5:22 PM
Unknown Object (File)
Nov 28 2024, 8:24 AM
Unknown Object (File)
Oct 28 2024, 6:26 PM
Unknown Object (File)
Oct 28 2024, 6:25 PM
Subscribers

Details

Summary

Cache pid of the remote process in the struct xucred. Do not bump XUCRED_VERSION as struct layout is not changed.

PR: 215202

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Also cache client process pid

I assume you used a union in struct xucred because a pointer has a different size on different architectures? You could use something like this:

pid_t cr_pid;
u_char _cr_unused1[sizeof(void *)-sizeof(pid_t)];

But perhaps that's not really an improvement.

This revision is now accepted and ready to land.May 27 2019, 1:07 PM
In D20415#440959, @tijl wrote:

I assume you used a union in struct xucred because a pointer has a different size on different architectures? You could use something like this:

sure

pid_t cr_pid;
u_char _cr_unused1[sizeof(void *)-sizeof(pid_t)];

But perhaps that's not really an improvement.

my variant is better for static struct xucred initialization
thanks

This revision was automatically updated to reflect the committed changes.