Enable build/install DTrace tests on amd64
AcceptedPublic
Actions

Authored by lwhsu on Apr 29 2019, 3:44 PM.

Details

Reviewers

markj
emaste
gnn

Summary

Enable build/install DTrace tests on amd64.

Also need to regen src.conf.5

Test Plan

cd /usr/tests/cddl/usr.sbin/dtrace && kyua test

Also, https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/ is green now.
Flaky tests, if found, should be mark skip.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23969
Build 22877: arc lint + arc unit

Event Timeline

lwhsu created this revision.Apr 29 2019, 3:44 PM

Herald added a reviewer: gnn. · View Herald TranscriptApr 29 2019, 3:44 PM

Herald added subscribers: imp, bdrewery. · View Herald Transcript

Harbormaster completed remote builds in B23969: Diff 56807.Apr 29 2019, 3:44 PM

Looks fine to me, but I think we need to fix the flaky tests first.

In D20096#432310, @markj wrote:

Looks fine to me, but I think we need to fix the flaky tests first.

Rather, if the intention is to skip flaky tests, we should let the DTrace job for some time to ensure that we can identify them all. I know of one, for which you submitted a PR, but I believe there are others.

In D20096#432316, @markj wrote:

In D20096#432310, @markj wrote:

Looks fine to me, but I think we need to fix the flaky tests first.

Rather, if the intention is to skip flaky tests, we should let the DTrace job for some time to ensure that we can identify them all. I know of one, for which you submitted a PR, but I believe there are others.

Agree, I am not intended to commit it immediately. But I think it's time to start to discuss turning this on by default. :-)

In D20096#432317, @lwhsu wrote:

Agree, I am not intended to commit it immediately. But I think it's time to start to discuss turning this on by default. :-)

Oh, and we don't have to wait for too long, there are some other flaky test cases in head so we can also deal with them together.

emaste added inline comments.Apr 29 2019, 7:12 PM

share/mk/src.opts.mk
408	Do we know how the tests do on other archs? I think it's fine to do this short-term but we should plan to have the tests on for all architectures where DTrace exists.

markj added inline comments.Apr 30 2019, 2:53 PM

share/mk/src.opts.mk
408	It'll take substantial effort to get them all passing on i386. I'm not sure about other arches, but I expect the test suite is in pretty bad shape everywhere except amd64.