Page MenuHomeFreeBSD

Don't panic for empty CCM requests.
ClosedPublic

Authored by jhb on Apr 24 2019, 10:45 PM.
Tags
None
Referenced Files
F102745881: D20043.diff
Sat, Nov 16, 3:34 PM
Unknown Object (File)
Oct 11 2024, 2:31 AM
Unknown Object (File)
Oct 6 2024, 8:05 AM
Unknown Object (File)
Sep 30 2024, 6:41 PM
Unknown Object (File)
Sep 25 2024, 1:42 AM
Unknown Object (File)
Sep 24 2024, 5:19 PM
Unknown Object (File)
Sep 17 2024, 9:28 AM
Unknown Object (File)
Sep 8 2024, 3:04 PM
Subscribers

Details

Summary

A request to encrypt an empty payload without any AAD is unusual, but
it is defined behavior. Removing this assertion removes a panic and
instead returns the correct tag for an empty buffer.

Test Plan
  • 'cryptocheck -d soft -va aes-ccm 0' now gets a result matching OpenSSL instead of triggering a panic

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Something made me think that it was not acceptable, but now I can't remember what it was, so it's clearly wrong.

This revision is now accepted and ready to land.Apr 24 2019, 10:46 PM

Yeah, I think we talked about this in one of sef@'s reviews. It might've been a later one, though.

This revision was automatically updated to reflect the committed changes.