Page MenuHomeFreeBSD

Don't panic for empty CCM requests.
ClosedPublic

Authored by jhb on Apr 24 2019, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 5:31 AM
Unknown Object (File)
Dec 20 2024, 5:25 PM
Unknown Object (File)
Dec 20 2024, 4:47 PM
Unknown Object (File)
Dec 20 2024, 11:48 AM
Unknown Object (File)
Dec 3 2024, 12:34 AM
Unknown Object (File)
Nov 16 2024, 6:31 PM
Unknown Object (File)
Nov 16 2024, 5:47 PM
Unknown Object (File)
Nov 16 2024, 3:34 PM
Subscribers

Details

Summary

A request to encrypt an empty payload without any AAD is unusual, but
it is defined behavior. Removing this assertion removes a panic and
instead returns the correct tag for an empty buffer.

Test Plan
  • 'cryptocheck -d soft -va aes-ccm 0' now gets a result matching OpenSSL instead of triggering a panic

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Something made me think that it was not acceptable, but now I can't remember what it was, so it's clearly wrong.

This revision is now accepted and ready to land.Apr 24 2019, 10:46 PM

Yeah, I think we talked about this in one of sef@'s reviews. It might've been a later one, though.

This revision was automatically updated to reflect the committed changes.