Differential D20009

[PowerPC64] pseries-llan: increment packet output counters on error and success
ClosedPublic
Actions

Authored by alfredo on Apr 22 2019, 3:30 PM.

Details

Reviewers

Commits

rS346590: [PowerPC64] pseries-llan: increment packet output counters on error and success

Summary

when using pseries-llan driver, Opkts and Oerrs counters (netstat -i) are always zero. This patch adds an small error handling to increment these counters.

Test Plan

Test network interface on QEMU-PowerPC64 with kernel built with both ELFv1 and ELFv2 ABIs

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23819
Build 22760: arc lint + arc unit

Event Timeline

alfredo created this revision.Apr 22 2019, 3:30 PM

Herald added subscribers: bdragon, jhibbits. · View Herald TranscriptApr 22 2019, 3:30 PM

Harbormaster completed remote builds in B23819: Diff 56489.Apr 22 2019, 3:30 PM

I think this really is two different revisions: Fix hypercalls on ELFv2, and fix ifnet counters on llan.

jhibbits requested changes to this revision.Apr 22 2019, 3:38 PM

jhibbits added a reviewer: jhibbits.

alfredo retitled this revision from [PowerPC64] fix pseries llan driver not working on ELFv2 ABI kernel to [PowerPC64] fix pseries llan driver not working on ELFv2 ABI kernel and increment packet output counters on success and error.Apr 22 2019, 3:52 PM

alfredo edited the summary of this revision. (Show Details)

alfredo edited the test plan for this revision. (Show Details)

alfredo added a subscriber: luporl.Apr 22 2019, 3:57 PM