Use more descriptive algorithm names in skip messages.
ClosedPublic
Actions

Authored by jhb on Apr 19 2019, 10:15 PM.

Details

Reviewers

cem
ngie
jmg

Commits

rS346615: Use more descriptive algorithm names in skip messages.

Test Plan

faked that ccr0 couldn't do AES in cryptotest.py and then ran it with -v.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 23778
Build 22725: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 19 2019, 10:15 PM

Harbormaster completed remote builds in B23778: Diff 56411.Apr 19 2019, 10:15 PM

No objection, although it's somewhat moot because the lists are shared (aesmodules, shamodules). Unless you plan to change that.

This revision is now accepted and ready to land.Apr 19 2019, 10:17 PM

jhb added a child revision: D19978: Test the AES-CCM test vectors from the NIST Known Answer Tests..Apr 19 2019, 10:17 PM

It is mostly moot and I don't really plan to change it currently. At some point I might instead make it just try to create a single test session for each algorithm up front and skip if it gets EOPNOTSUPP. It also should not have a hardcoded list of device names. It should really take an optional command line argument for what devices you want to test or use some method to enumerate the available devices (might have to add something to OCF to support the latter).