Page MenuHomeFreeBSD
Differential D19005

ifconfig: fix endianness bug displaying pfsync interfaces
ClosedPublic
Actions

Authored by asomers on Jan 28 2019, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 15 2024, 1:56 PM
Unknown Object (File)
Oct 15 2024, 1:56 PM
Unknown Object (File)
Oct 15 2024, 1:55 PM
Unknown Object (File)
Oct 15 2024, 1:55 PM
Unknown Object (File)
Oct 15 2024, 1:44 PM
Unknown Object (File)
Sep 30 2024, 6:18 PM
Unknown Object (File)
Sep 28 2024, 11:28 PM
Unknown Object (File)
Sep 21 2024, 11:32 AM
View All 55 Files
Subscribers
imp
kp

Details

Reviewers
glebius
kp
Commits
rS345397: MFC r343530, r344559
rS344138: MFC r343530:
rS343530: ifconfig: fix endianness bug displaying pfsync interfaces
Summary

ifconfig: fix endianness bug displaying pfsync interfaces

Test Plan

ifconfig tun0 create
kldload pfsync
ifconfig pfsync syncdev tun0
ifconfig pfsync0 # Verify that peer address doesn't display

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22216
Build 21425: arc lint + arc unit

Event Timeline

asomers created this revision.Jan 28 2019, 4:48 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 28 2019, 4:48 PM
Harbormaster completed remote builds in B22216: Diff 53316.Jan 28 2019, 4:48 PM
kp added a subscriber: kp.Jan 28 2019, 5:10 PM
kp added inline comments.
sbin/ifconfig/ifpfsync.c
198

I think that needs to be 'htonl()'.

It'll work of course, but INADDR_PFSYNC_GROUP is in host byte order, and preq.pfsyncr_syncpeer.s_addr is in network order, so you want to go from host to network order, and not the other way around.

asomers added inline comments.Jan 28 2019, 5:23 PM
sbin/ifconfig/ifpfsync.c
198

Oh, my mistake. I saw the definition and read it as a byte array, ignoring the leading (in_addr_t)

#define INADDR_PFSYNC_GROUP     ((in_addr_t)0xe00000f0) /* 224.0.0.240 */
asomers updated this revision to Diff 53324.Jan 28 2019, 5:24 PM

s/ntohl/htonl

Harbormaster completed remote builds in B22222: Diff 53324.Jan 28 2019, 5:24 PM
kp accepted this revision.Jan 28 2019, 5:44 PM
This revision is now accepted and ready to land.Jan 28 2019, 5:44 PM
Closed by commit rS343530: ifconfig: fix endianness bug displaying pfsync interfaces (authored by asomers). · Explain WhyJan 28 2019, 6:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
6 lines

Diff 53316

View Options

sbin/ifconfig/ifpfsync.c

Loading...