stand/i386: rename .s to .S to use Clang IAS
ClosedPublic
Actions

Authored by emaste on Nov 28 2018, 3:55 PM.

Details

Reviewers

imp
kevans
tsoome

Commits

rS341437: stand/i386: rename .s to .S to use Clang IAS

Summary

As part of the migration away from obsolete binutils we want to retire GNU as. Most assembly files used on amd64 have a .S extension and (via rules in share/mk/bsd.suffixes.mk) are assembled with Clang's Integrated Assembler (IAS). Rename files in stand/i386 to .S to use the integrated assembler.

Clang's IAS supports the defsym option (via -Wa,) but only with one dash, not two. As both -defsym and --defsym are accepted by GNU as, use the former.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Nov 28 2018, 3:55 PM

emaste added reviewers: kevans, tsoome.Nov 30 2018, 7:42 PM

tsoome accepted this revision.Dec 3 2018, 7:05 PM

This revision is now accepted and ready to land.Dec 3 2018, 7:05 PM

rS341437

Closed by commit rS341437: stand/i386: rename .s to .S to use Clang IAS (authored by emaste). · Explain WhyDec 3 2018, 7:19 PM

This revision was automatically updated to reflect the committed changes.

I looked at this on my phone a few days ago and meant to stamp it with LGTM when I got back to my computer, but that fell through the cracks.

In D18369#392138, @imp wrote:

I looked at this on my phone a few days ago and meant to stamp it with LGTM when I got back to my computer, but that fell through the cracks.

OK, thanks for the followup!

On amd64 there's one more change ready to go in D18344, then just skein_block_asm.s to deal with.