Add a pwm subsystem so we can configure pwm controller from kernel and userland.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions
A few easy fixes for both man pages (I annotated only, but they apply to both).
Thanks for the writeup.
| share/man/man9/pwm.9 | ||
|---|---|---|
| 58 ↗ | (On Diff #50384) | interfal == interface or interval? |
| 58 ↗ | (On Diff #50384) | s/allow device drive/allows the device driver/ |
| 59 ↗ | (On Diff #50384) | s/device/devices/ |
| 66 ↗ | (On Diff #50384) | s/is/if/ |
| 67 ↗ | (On Diff #50384) | s/is/if/ |
| 79 ↗ | (On Diff #50384) | s/channel/channels/ |
| 82 ↗ | (On Diff #50384) | s/appear/appeared/ |
Comment Actions
Sometimes you write pwm and sometimes PWM.
I'd either change everything to PWM or to .Nm pwm (I am not sure if sole .Nm is going to work).
Cheers :)
| share/man/man9/pwm.9 | ||
|---|---|---|
| 63 ↗ | (On Diff #50386) | Missing .. |
| 65 ↗ | (On Diff #50386) | s/pwm/PWM/ |
| 66 ↗ | (On Diff #50386) | ... |
| 67 ↗ | (On Diff #50386) | .Er EBUSY |
| 75 ↗ | (On Diff #50386) | s/pwm/PWM/ |
| 77 ↗ | (On Diff #50386) | s/pwm/PWM/ |
| 82 ↗ | (On Diff #50386) | s/pwm/PWM/ |
| 84 ↗ | (On Diff #50386) | s/pwm/PWM/ |
| share/man/man9/pwmbus.9 | ||
| 59 ↗ | (On Diff #50386) | This paragraph has similar issues to the one from the other manual page reviewed by @bcr. |
Comment Actions
Looks good Manu!
What do you think about a method to get the channel resolution ? Could be in bits.
| sys/dev/pwm/pwmbus_if.m | ||
|---|---|---|
| 93 ↗ | (On Diff #50386) | stray ';' |
| usr.sbin/pwm/pwm.c | ||
| 1 ↗ | (On Diff #50386) | no license in this file. |
| 46 ↗ | (On Diff #50386) | I guess the '-f' option is missing here. |
| 86 ↗ | (On Diff #50386) | ';' not needed. |
Comment Actions
Two comments for the updated version.
| share/man/man9/pwm.9 | ||
|---|---|---|
| 58 ↗ | (On Diff #50384) | It still reads "device drive" instead of "device driver" here. Or is it just device without the driver? "drive" is definitely wrong here. |
| share/man/man9/pwmbus.9 | ||
| 59 ↗ | (On Diff #50386) | This is still the old version? Should be fixing the same issue as above (s/allow device/allows the device/) |
| share/man/man9/pwm.9 | ||
|---|---|---|
| 58 ↗ | (On Diff #50384) | Yeah sorry I missed this part earlier. |
Comment Actions
It looks like you forgot to update the other manual page as well. :)
| share/man/man9/pwmbus.9 | ||
|---|---|---|
| 65 ↗ | (On Diff #50999) | .Nm pwmbus |
| 67 ↗ | (On Diff #50999) | s/pwm/PWM/ |
| 68 ↗ | (On Diff #50999) | .Er EINVAL |
| 79 ↗ | (On Diff #50999) | s/pwm/PWM |
| 81 ↗ | (On Diff #50999) | s/pwm/PWM |
| 86 ↗ | (On Diff #50999) | .Nm pwmbus |
| 88 ↗ | (On Diff #50999) | .Nm pwmbus |
| usr.sbin/pwm/pwm.c | ||
|---|---|---|
| 69 ↗ | (On Diff #51009) | Where is HAVE_CAPSICUM defined? |
Comment Actions
Remove HAVE_CAPSICUM as it's deprecated.
While here correct a typo in cap_right/s_init
| usr.sbin/pwm/pwm.c | ||
|---|---|---|
| 137 ↗ | (On Diff #51927) | s/cap_rights_limit/caph_rights_limit/ Otherwise we need to check the errno. |