Page MenuHomeFreeBSD
Differential D17826

Use atomic_fcmpset in pmap_promote_pde().
AbandonedPublic
Actions

Authored by markj on Nov 3 2018, 5:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 16, 3:10 AM
Unknown Object (File)
Dec 4 2024, 5:14 PM
Unknown Object (File)
Dec 4 2024, 5:14 PM
Unknown Object (File)
Dec 4 2024, 5:14 PM
Unknown Object (File)
Dec 4 2024, 4:52 PM
Unknown Object (File)
Nov 18 2024, 7:09 PM
Unknown Object (File)
Nov 13 2024, 12:47 PM
Unknown Object (File)
Oct 2 2024, 8:41 PM
View All 35 Files
Subscribers
None

Details

Reviewers
alc
kib
Summary

Something I noticed while reading code, no functional change intended.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20633
Build 20050: arc lint + arc unit

Event Timeline

markj created this revision.Nov 3 2018, 5:12 PM
Harbormaster completed remote builds in B20611: Diff 49973.Nov 3 2018, 5:12 PM
markj edited the summary of this revision. (Show Details)Nov 3 2018, 5:23 PM
markj added reviewers: alc, kib.
kib accepted this revision.Nov 4 2018, 5:12 PM
This revision is now accepted and ready to land.Nov 4 2018, 5:12 PM
alc added inline comments.Nov 4 2018, 6:10 PM
sys/amd64/amd64/pmap.c
4873

I believe that this line is still needed after the conversion.

4898

Ditto.

sys/i386/i386/pmap.c
3556

Ditto.

3582

This case looks okay.

markj updated this revision to Diff 50016.Nov 5 2018, 4:07 AM
markj marked 3 inline comments as done.
  • Fix the bugs pointed out by alc. I mistakenly thought that fcmpset updates the expected value upon success.
This revision now requires review to proceed.Nov 5 2018, 4:07 AM
Harbormaster completed remote builds in B20633: Diff 50016.Nov 5 2018, 4:07 AM
alc added inline comments.Nov 5 2018, 7:12 AM
sys/i386/i386/pmap.c
3553

Have you tried building a PAE kernel? I suspect that &newpde will provoke a warning.

3579

Ditto.

markj marked an inline comment as done.Nov 6 2018, 5:05 PM
markj added inline comments.
sys/i386/i386/pmap.c
3553

Oh, I'm surprised that we're using 32-bit cmpset here then. I guess we avoid cmpxchg8b here as a micro-optimization, since PG_RW is in the lower 32 bits?

alc added inline comments.Nov 9 2018, 3:49 AM
sys/i386/i386/pmap.c
3553

Yes, and we also avoid conditional compilation.

alc accepted this revision.May 18 2019, 8:24 PM
This revision is now accepted and ready to land.May 18 2019, 8:24 PM
markj abandoned this revision.Sep 16 2021, 2:50 PM

Commit 3687797618b6c978ad733bd206a623e5df47dbe3 , I do not think it is worth touching i386.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
8 lines
i386/
i386/
8 lines

Diff 50016

View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/i386/i386/pmap.c

Loading...