Page MenuHomeFreeBSD

netmap: add load balancer program
ClosedPublic

Authored by vmaffione on Oct 28 2018, 8:40 AM.
Tags
None
Referenced Files
F110044753: D17735.diff
Wed, Feb 12, 10:08 PM
Unknown Object (File)
Mon, Feb 10, 6:44 AM
Unknown Object (File)
Sun, Feb 9, 7:54 PM
Unknown Object (File)
Fri, Feb 7, 4:16 PM
Unknown Object (File)
Sat, Feb 1, 4:53 PM
Unknown Object (File)
Fri, Jan 24, 10:40 AM
Unknown Object (File)
Dec 31 2024, 8:28 PM
Unknown Object (File)
Dec 14 2024, 6:26 PM
Subscribers

Details

Summary

Add the lb program, which is able to load-balance input traffic received from a netmap port over M groups, with N netmap pipes in each group.
Each received packet is forwarded to one of the pipes chosen from each group (using an L3/L4 connection-consistent hash function).
This also adds a man page for lb and some cross-references in related man pages.

Test Plan

Man page tested with igor and mandoc -Tlint.
Used in production environments for at least a year.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This patch depends on https://reviews.freebsd.org/D17698 , because of the changes to ctrs.h.

Minor fixes to the man pages.

This revision is now accepted and ready to land.Oct 28 2018, 11:48 AM
0mp requested changes to this revision.Oct 29 2018, 10:14 AM

Most of my comments are just suggestions. :)

tools/tools/netmap/bridge.8
74 ↗(On Diff #49721)

Remember to bump the date in this manual page as well.

tools/tools/netmap/lb.8
57 ↗(On Diff #49721)

mdoc renders two spaces after the closing bracket.

I opened a bug report for that: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232779

59 ↗(On Diff #49721)

How about:

.It Fl p Ar name Ns Cm : Ns Ar number | number

: is not an argument, it is a command modifier.

64 ↗(On Diff #49721)

Do you think that we would benefit from quoting those names?

will be called
.Dq Ar name Ns Em }0
to
.Dq Ar name No Ns Em } Ns Aq Ar number No - 1 .
72 ↗(On Diff #49721)

Typo: Fl p

This revision now requires changes to proceed.Oct 29 2018, 10:14 AM
vmaffione marked 5 inline comments as done.

Implemented the changes suggested by the reviewers.

Is the man page looking better now?

Just on thing on my side. Sorry about that!

Otherwise, LGTM.

tools/tools/netmap/lb.8
59 ↗(On Diff #49759)

I'm sorry: Cm has to be escaped here to apply to ::

.It Fl p Ar name Ns Cm \&: Ns Ar number | number

Then you'll see that : is in fact bold.

This revision is now accepted and ready to land.Oct 31 2018, 2:26 PM
vmaffione marked an inline comment as done.

Thanks! I did not get you wanted the ":" bold.

This revision now requires review to proceed.Oct 31 2018, 2:35 PM
This revision is now accepted and ready to land.Oct 31 2018, 2:36 PM

Thanks for the review. However, I need to commit this https://reviews.freebsd.org/D17698 first.

This revision was automatically updated to reflect the committed changes.