Page MenuHomeFreeBSD
Differential D16734

sys/types.h: avoid using terse macro _M
ClosedPublic
Actions

Authored by emaste on Aug 15 2018, 9:43 PM.
Tags
None
Referenced Files
F110615834: D16734.diff
Thu, Feb 20, 10:57 PM
Unknown Object (File)
Dec 12 2024, 6:37 PM
Unknown Object (File)
Nov 4 2024, 7:15 AM
Unknown Object (File)
Sep 17 2024, 2:13 AM
Unknown Object (File)
Aug 11 2024, 9:46 PM
Unknown Object (File)
Jun 24 2024, 7:56 PM
Unknown Object (File)
Jun 22 2024, 6:57 PM
Unknown Object (File)
Jun 3 2024, 6:23 PM
View All 26 Files
Subscribers
imp

Details

Reviewers
dim
Commits
rS340079: sys/types.h: avoid using terse macro _M
Summary

Although _M is reserved for use by the implementation it is rather non-descriptive and conflicted with a libc++ test. Just rename to _Major and _Minor to avoid conflicts.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Aug 15 2018, 9:43 PM
dim accepted this revision.Aug 16 2018, 5:10 AM

LGTM, maybe also rename the arguments of the preceding macro, for consistency?

This revision is now accepted and ready to land.Aug 16 2018, 5:10 AM
Closed by commit rS340079: sys/types.h: avoid using terse macro _M (authored by emaste). · Explain WhyNov 2 2018, 8:48 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 2 2018, 8:48 PM

Revision Contents
Changeset List

PathSize
sys/
sys/
6 lines

Diff 46743

View Options

sys/sys/types.h

Loading...