This is not strictly required for crossbuilding but having lots of warnings
from bsd.linker.mk in the output was making it hard to see the actual
warning messages.
Details
- Reviewers
emaste bdrewery imp jhb - Commits
- rS364191: Make bsd.linker.mk work with the MacOS linker
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 14957 Build 15069: arc lint + arc unit
Event Timeline
share/mk/bsd.linker.mk | ||
---|---|---|
57 | Were it not for the weird exit value, you could do this more simply as ld <blah> --version || ld <blah> -v || echo none. I'm surprised that 'head' results in an exit of 141 though. Is head returning that? |
share/mk/bsd.linker.mk | ||
---|---|---|
57 | LD can print more than one line and head exits after the first line has been printed so it dies with a pipe closed error. This is only a problem when changing the bmake shell to use -o pipefail, so I can remove it if you prefer. |
I doubt the version matters, but we could avoid adding ld.bfd/ld.lld specific flags during bootstrapping.
There currently aren't any, but that might change (and silencing the warnings is quite useful).
Yeah, it's specifically the version I'm wondering about, although I suppose it would be just as strange to detect macos linker and use a fake version (e.g. 0.0.0)