These headers are required in order to build the bootstrap tools on macOS
and Linux. A follow-up commit will add implementations of functions that
don't exist on those operating systems to -legacy when bootstrapping.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 32822 Build 30237: arc lint + arc unit
Event Timeline
Comment Actions
A few whitespace and comment formatting nits (not every instance marked), but generally looks fine.
tools/build/cross-build/include/common/machine/atomic.h | ||
---|---|---|
45 ↗ | (On Diff #75514) | probably remove this line |
tools/build/cross-build/include/linux/stdlib.h | ||
62 | I'd tend to pick one indent level for all the functions. | |
tools/build/cross-build/include/linux/sys/param.h | ||
44 | /* on separate line | |
tools/build/cross-build/include/linux/sys/stat.h | ||
41 | Too many *s | |
45 | Probably use C-style comment. | |
tools/build/cross-build/include/mac/stdlib.h | ||
45 | should pick one indentation style. |
tools/build/cross-build/include/common/machine/atomic.h | ||
---|---|---|
45 ↗ | (On Diff #75514) | In fact I think this header is no longer needed. Will see if I can remove it. |
tools/build/cross-build/include/common/pwd.h | ||
---|---|---|
56 | Normally return (1); |