LLD to BROKEN_OPTIONS when building on non-FreeBSD
ClosedPublic
Actions

Authored by arichardson on Feb 7 2018, 4:49 PM.

Details

Reviewers

emaste
imp
bdrewery
jhb
dim

Commits

rS364122: Add CLANG/LLD/LLD to BROKEN_OPTIONS when building on non-FreeBSD

Summary

These tools require a bootstrap llvm-tblgen/clang-tblgen and that cannot
be built with the current make infrastructure: the config header is not
correct for Linux/macOS and we don't include the CMakeLists.txt in contrib
so we can't generate one that would be correct.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14848
Build 14962: arc lint + arc unit

Event Timeline

arichardson created this revision.Feb 7 2018, 4:49 PM

Harbormaster completed remote builds in B14848: Diff 39008.Feb 7 2018, 4:49 PM

emaste accepted this revision.Feb 27 2019, 2:48 AM

This revision is now accepted and ready to land.Feb 27 2019, 2:48 AM

No longer accurate, I have changes to allow bootstrapping localedef and CDDL code.

Now only clang+lld+lldb are broken

Harbormaster completed remote builds in B32830: Diff 75548.Aug 7 2020, 11:00 AM

arichardson retitled this revision from crossbuild: disable MK_* options that won't work on non-FreeBSD systems to Add CLANG/LLD/LLD to BROKEN_OPTIONS when building on non-FreeBSD.Aug 7 2020, 11:00 AM

arichardson edited the summary of this revision. (Show Details)

arichardson added a reviewer: dim.

fix typo in comment

Harbormaster completed remote builds in B32831: Diff 75549.Aug 7 2020, 11:02 AM

arichardson added a child revision: D16767: Add a tools/build/make.py script that bootstraps bmake and then runs the build.Aug 7 2020, 3:30 PM

No comment on the list of options, but the method being used is proper.

This revision is now accepted and ready to land.Aug 7 2020, 8:11 PM

Unfortunately generating the config headers requires CMake, so getting that bootstrapped is rather tricky. In that case people would be better off using the upstream sources directly, and installing all prerequisites in some other way.

That said, better to error out on this earlier than later. :)