Page MenuHomeFreeBSD

crossbuild: Make the CHECK_TIME variable work on Linux
ClosedPublic

Authored by arichardson on Feb 1 2018, 2:20 PM.
Tags
None
Referenced Files
F107603508: D14157.diff
Thu, Jan 16, 12:54 PM
Unknown Object (File)
Wed, Dec 18, 2:05 PM
Unknown Object (File)
Nov 20 2024, 7:49 AM
Unknown Object (File)
Oct 18 2024, 2:24 AM
Unknown Object (File)
Oct 6 2024, 8:24 AM
Unknown Object (File)
Oct 2 2024, 8:23 AM
Unknown Object (File)
Oct 2 2024, 8:23 AM
Unknown Object (File)
Oct 2 2024, 8:22 AM
Subscribers
None

Details

Summary

Linux /usr/bin/find doesn't understand the -mtime -0s flag.
Instead create a temporary file and compare that file's mtime to
sys/sys/param.h to check whether the clock is correct.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14727
Build 14848: arc lint + arc unit

Event Timeline

Makefile
360

This is now wrong. This changes from 0s to 0 days. Due to funky roundings, this tests to see if the sys/sys/param.h file is one day or less old (or in the future), whereas on FreeBSD it tests if it is 1 second old or in the future. The difference is important and will lead to false positives.

"touch /tmp/junk && find ${.CURDIR}/sys/sys/param.h -newer /tmp/junk && rm /tmp/junk" would do the same thing and be portable...

arichardson edited the summary of this revision. (Show Details)

Use a temporary file instead

imp added inline comments.
Makefile
355–360

Thanks!

This revision is now accepted and ready to land.Feb 5 2018, 5:12 PM
This revision was automatically updated to reflect the committed changes.